Page MenuHomePhabricator
Differential D8279

[web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 4:36 PM
Unknown Object (File)
Wed, Mar 5, 4:02 PM
Unknown Object (File)
Wed, Mar 5, 4:02 PM
Unknown Object (File)
Wed, Mar 5, 4:02 PM
Unknown Object (File)
Wed, Mar 5, 4:02 PM
Unknown Object (File)
Wed, Mar 5, 4:01 PM
Unknown Object (File)
Wed, Mar 5, 3:57 PM
Unknown Object (File)
Mon, Mar 3, 4:52 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
inka
michal
kamil
Commits
rCOMM370a9b620d5d: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`
Summary
  1. Show spinner when save avatar request is in progress.
  2. Disable button when save avatar request is in progress.
  3. Sneak in disable button change for CommunityCreationModal

Depends on D8278

Test Plan

Works as expected:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 21 2023, 12:52 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 12:52 PM
atul edited the test plan for this revision. (Show Details)Jun 21 2023, 12:53 PM
atul added inline comments.Jun 21 2023, 12:55 PM
web/sidebar/community-creation/community-creation-modal.react.js
196 ↗(On Diff #27977)

Sorry snuck this quick change in here to keep things symmetrical

atul published this revision for review.Jun 21 2023, 12:57 PM
rohan added inline comments.Jun 21 2023, 1:04 PM
web/avatars/emoji-avatar-selection-modal.react.js
106–107 ↗(On Diff #27977)

The video looks good, just wondering if saveButtonContent meant to be inside of the div?

Harbormaster completed remote builds in B20405: Diff 27977.Jun 21 2023, 1:11 PM
atul added inline comments.Jun 21 2023, 2:09 PM
web/avatars/emoji-avatar-selection-modal.react.js
106–107 ↗(On Diff #27977)

Yeah, fixed this in next diff. I'll rebase and fix it here instead

atul added a child revision: D8280: [web] Display `errorMessage` in `saveAvatarButton` on failure.Jun 21 2023, 2:09 PM
atul updated this revision to Diff 27979.Jun 21 2023, 2:12 PM

address @rohan's feedback

Harbormaster completed remote builds in B20407: Diff 27979.Jun 21 2023, 2:31 PM
rohan accepted this revision.Jun 22 2023, 7:25 AM
This revision is now accepted and ready to land.Jun 22 2023, 7:25 AM
atul updated this revision to Diff 28077.Jun 23 2023, 1:53 PM

rebase and land

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMM370a9b620d5d: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM370a9b620d5d: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.
Harbormaster completed remote builds in B20491: Diff 28077.Jun 23 2023, 2:15 PM

Revision Contents
Changeset List

PathSize
web/
avatars/
7 lines
15 lines
sidebar/
community-creation/
1 line

Diff 27979

View Options

web/avatars/emoji-avatar-selection-modal.css

  • This file was added.
project(comm-services-common)
cmake_minimum_required(VERSION 3.4)
include(GNUInstallDirs)
# Export reactors
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/client-base-reactors)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/server-base-reactors)
file(GLOB COMMON_HDRS
${CMAKE_CURRENT_SOURCE_DIR}/*.h
)
file(GLOB COMMON_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
)
add_library(comm-services-common
${COMMON_HDRS}
${COMMON_SRCS}
)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(protobuf REQUIRED)
find_package(gRPC REQUIRED)
target_link_libraries(comm-services-common
gRPC::grpc++
${AWSSDK_LINK_LIBRARIES}
)
# reference local directory when building, use installation path when installing
target_include_directories(comm-services-common
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
install(TARGETS comm-services-common EXPORT comm-services-common-export
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT comm-services-common
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
)
install(FILES ${COMMON_HDRS} DESTINATION include)
# For development purposes, can point cmake to this directory if doing development
export(TARGETS comm-services-common
NAMESPACE comm-services-common::
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/comm-services-common/comm-services-common-targets.cmake
)
# For installation
install(EXPORT comm-services-common-export
FILE comm-services-common-targets.cmake
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/comm-tool
NAMESPACE comm-services-common::
)
View Options

web/avatars/emoji-avatar-selection-modal.react.js

  • This file was added.
project(comm-services-common)
cmake_minimum_required(VERSION 3.4)
include(GNUInstallDirs)
# Export reactors
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/client-base-reactors)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/server-base-reactors)
file(GLOB COMMON_HDRS
${CMAKE_CURRENT_SOURCE_DIR}/*.h
)
file(GLOB COMMON_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
)
add_library(comm-services-common
${COMMON_HDRS}
${COMMON_SRCS}
)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(protobuf REQUIRED)
find_package(gRPC REQUIRED)
target_link_libraries(comm-services-common
gRPC::grpc++
${AWSSDK_LINK_LIBRARIES}
)
# reference local directory when building, use installation path when installing
target_include_directories(comm-services-common
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
install(TARGETS comm-services-common EXPORT comm-services-common-export
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT comm-services-common
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
)
install(FILES ${COMMON_HDRS} DESTINATION include)
# For development purposes, can point cmake to this directory if doing development
export(TARGETS comm-services-common
NAMESPACE comm-services-common::
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/comm-services-common/comm-services-common-targets.cmake
)
# For installation
install(EXPORT comm-services-common-export
FILE comm-services-common-targets.cmake
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/comm-tool
NAMESPACE comm-services-common::
)
View Options

web/sidebar/community-creation/community-creation-modal.react.js

  • This file was added.
project(comm-services-common)
cmake_minimum_required(VERSION 3.4)
include(GNUInstallDirs)
# Export reactors
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/client-base-reactors)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/server-base-reactors)
file(GLOB COMMON_HDRS
${CMAKE_CURRENT_SOURCE_DIR}/*.h
)
file(GLOB COMMON_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
)
add_library(comm-services-common
${COMMON_HDRS}
${COMMON_SRCS}
)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(protobuf REQUIRED)
find_package(gRPC REQUIRED)
target_link_libraries(comm-services-common
gRPC::grpc++
${AWSSDK_LINK_LIBRARIES}
)
# reference local directory when building, use installation path when installing
target_include_directories(comm-services-common
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
install(TARGETS comm-services-common EXPORT comm-services-common-export
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT comm-services-common
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
)
install(FILES ${COMMON_HDRS} DESTINATION include)
# For development purposes, can point cmake to this directory if doing development
export(TARGETS comm-services-common
NAMESPACE comm-services-common::
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/comm-services-common/comm-services-common-targets.cmake
)
# For installation
install(EXPORT comm-services-common-export
FILE comm-services-common-targets.cmake
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/comm-tool
NAMESPACE comm-services-common::
)