Page MenuHomePhabricator
Differential D8292

[lib][native] Extract invite link url
ClosedPublic
Actions

Authored by tomek on Jun 22 2023, 7:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 3:24 AM
Unknown Object (File)
Sat, Mar 15, 5:59 PM
Unknown Object (File)
Sat, Mar 15, 9:01 AM
Unknown Object (File)
Wed, Mar 12, 4:16 AM
Unknown Object (File)
Tue, Mar 11, 5:16 AM
Unknown Object (File)
Mar 6 2025, 5:07 PM
Unknown Object (File)
Mar 6 2025, 5:07 PM
Unknown Object (File)
Mar 6 2025, 5:07 PM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM8f6f5f900738: [lib][native] Extract invite link url
Summary

Extract the link url to a common place so that it can be reused.

Depends on D8237

Test Plan

Check if the link is displayed correctly in both places.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
facts/
7 lines
native/
invite-links/
3 lines
3 lines

Diff 28106

View Options

lib/facts/links.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

native/invite-links/manage-public-link-screen.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

native/invite-links/view-invite-links-screen.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines