Change button label after successful action.
Depends on D8246
Details
Details
Click copy button and check if the label changes.
Click it repeatedly and check if the label changes back only after 2s. from the last click.
Click it and close modal - nothing should break.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/invite-links/view-invite-link-modal.react.js | ||
|---|---|---|
| 33–40 ↗ | (On Diff #28006) | I think this code is duplicated, wondering about wrapping this in a hook, what do you think? |
| web/invite-links/view-invite-link-modal.react.js | ||
|---|---|---|
| 33–40 ↗ | (On Diff #28006) | Good idea! Created a generic hook with resetting state for this. |
| lib/hooks/useResettingState.js | ||
|---|---|---|
| 9 ↗ | (On Diff #28150) | probably having (T => T) | T defined as a separate type in hook-types.js as it can be reused might be a good option, but I do not feel strongly about this |
| lib/hooks/useResettingState.js | ||
|---|---|---|
| 9 ↗ | (On Diff #28150) | Might be a good idea, but I don't think we're going to use it frequently - we can add it when there are more usages. |
| lib/hooks/useResettingState.js | ||
|---|---|---|
| 1 | We generally name files use-resetting-state.js | |