Details

Reviewers

michal
varun
• patryk
• jon

Commits

rCOMMff3a70e0cb1e: [blob-service] Create business logic abstraction

Summary

Part of ENG-4269.

Previously, the blob service logic was handled directly in the HTTP handlers (and doubled in the gRPC).
We're gonna introduce cleanup tasks too, so decided to abstract it out.

Depends on D8451.

Test Plan

Tested later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 9 2023, 9:04 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 9:04 PM

bartek added a child revision: D8454: [blob-service] Implement download logic with new db.Jul 9 2023, 9:05 PM

Harbormaster completed remote builds in B20822: Diff 28509.Jul 9 2023, 9:28 PM

bartek edited the summary of this revision. (Show Details)Jul 10 2023, 6:34 AM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Jul 10 2023, 7:42 AM

rust LGTM, would like for someone else to take a look

varun accepted this revision.Jul 13 2023, 5:17 PM

This revision is now accepted and ready to land.Jul 13 2023, 5:17 PM

bartek edited the summary of this revision. (Show Details)Jul 21 2023, 8:15 AM

bartek added a parent revision: D8451: [blob-service] DB: Add holder management methods.

bartek removed a parent revision: D8452: [blob-service] DB: Add remaining client methods.

Rebase

Harbormaster failed remote builds in B21101: Diff 28912!Jul 25 2023, 8:38 AM

This revision was landed with ongoing or failed builds.Jul 25 2023, 8:44 AM

Closed by commit rCOMMff3a70e0cb1e: [blob-service] Create business logic abstraction. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMff3a70e0cb1e: [blob-service] Create business logic abstraction.

[blob-service] Create business logic abstraction
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28912

services/blob/src/main.rs

services/blob/src/service.rs

services/blob/src/tools.rs

[blob-service] Create business logic abstractionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28912

services/blob/src/main.rs

services/blob/src/service.rs

services/blob/src/tools.rs

[blob-service] Create business logic abstraction
ClosedPublic
Actions

Revision Contents
Changeset List