Details
Checked that the option shows for my local admin user only
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Shouldn't we add some sort of isDev check so we don't roll out this dummy button to users when a keyserver release is made?
Would I need this if I'm landing the entire stack once completed all at once? I thought I'd need that only if I was landing this early before landing the rest of the web stack was done
Re-requesting review because I don't think I need it if I'm landing the entire stack at once (and so my comment doesn't get lost), but let me know if I'm missing something!
agree with @rohan that isDev check shouldn't be necessary if we are landing stack all at once
Re-requesting review because I don't think I need it if I'm landing the entire stack at once
Ah yeah not necessary if landing the whole stack at once I guess. My preference is to ensure things are landable as-is (eg put things behind isDev), but this is also fine.