[native] Add dependency to generate QR codes on native
ClosedPublic
Actions

Authored by rohan on Aug 16 2023, 10:24 AM.

Details

Reviewers

atul
ginsu
tomek
varun
ashoat

Commits

rCOMM0a2f6fe55949: [native] Add dependency to generate QR codes on native

Summary

With React Native, it seems like the most popular QR generation library is react-native-qrcode-svg. It's not actively contributed on, but it's a pretty standardized implementation so that makes sense. Added benefits are:

Follows semver
Uses GitHub releases
A fair amount of customization options through props
MIT license

ENG-4610

Depends on D8821

Test Plan

Can successfully import the QRCode component on native

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Aug 16 2023, 10:24 AM

rohan edited the summary of this revision. (Show Details)Aug 16 2023, 10:26 AM

Harbormaster completed remote builds in B21802: Diff 29966.Aug 16 2023, 10:43 AM

rohan requested review of this revision.Aug 16 2023, 10:43 AM

Have you considered https://github.com/rosskhanas/react-qr-code? I found it on reactnative.directory. It looks like it's not quite as popular as react-native-qrcode-sv, but it's almost as popular, plus it works on both React and React Native and seems to have been updated more recently.

Passing back with question. Feel free to push back, I haven't compared these dependencies too closely

This revision now requires changes to proceed.Aug 16 2023, 1:03 PM

Yeah I've seen react-qr-code, I initially chose to not go with that as it seemed to be more of a 'barebones' QR code implementation. The main thing was if we wanted to add something like a logo or an image on the QR code down the line, the two packages (on web and here on native) support it, while react-qr-code doesn't.

More importantly though, it seems like react-qr-code uses qr.js underneath:

react-qr-code@2.0.12:
  version "2.0.12"
  resolved "https://registry.yarnpkg.com/react-qr-code/-/react-qr-code-2.0.12.tgz#98f99e9ad5ede46d73ab819e2dd9925c5f5d7a2d"
  integrity sha512-k+pzP5CKLEGBRwZsDPp98/CAJeXlsYRHM2iZn1Sd5Th/HnKhIZCSg27PXO58zk8z02RaEryg+60xa4vyywMJwg==
  dependencies:
    prop-types "^15.8.1"
    qr.js "0.0.0"

It seems to be completely unmaintained for the past several years: https://blog.sonatype.com/researcher-takes-over-qr.js-via-repo-hijacking.-is-the-npm-package-safe. The author of qrcode.react (the package we used for web) even decided to move away from using it

I think it's better to stay with the two packages that don't rely on qr.js, but ultimately happy to go with it if you think otherwise

Going to request review just so the discussion doesn't get lost. If you want to go with the react-qr-code package feel free to request changes again

rationale makes sense to me

rohan added a child revision: D8870: [native] Add a temporary sign in via QR code button on native.Aug 18 2023, 11:23 AM

Thanks for explaining!

This revision is now accepted and ready to land.Aug 18 2023, 4:00 PM

Rebase

This revision was landed with ongoing or failed builds.Aug 22 2023, 8:19 AM

Closed by commit rCOMM0a2f6fe55949: [native] Add dependency to generate QR codes on native (authored by rohan). · Explain Why

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM0a2f6fe55949: [native] Add dependency to generate QR codes on native.

Harbormaster completed remote builds in B22019: Diff 30230.Aug 22 2023, 8:36 AM