[native] Replace `scrollPos` instance variable w/ ref
ClosedPublic
Actions

Authored by atul on Sep 11 2023, 3:51 PM.

Details

Reviewers

ashoat
ginsu
rohan
tomek

Commits

rCOMM22479ac32638: [native] Replace `scrollPos` instance variable w/ ref

Summary

As part of converting ChatThreadList to a functional component we'll need to replace the scrollPos instance variable with a ref.

Depends on D9135

Test Plan

Things seem to continue to work as expected. Haven't used useRef a whole lot, so would be good to get feedback from reviewers w/ more familiarity.

Logging values seems to result in correct values:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 11 2023, 3:51 PM

atul published this revision for review.Sep 11 2023, 3:59 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B22509: Diff 30944.Sep 11 2023, 4:09 PM

ashoat accepted this revision.Sep 12 2023, 5:51 AM

This revision is now accepted and ready to land.Sep 12 2023, 5:51 AM

atul added a child revision: D9161: [native] Lift `onScroll` to `ConnectedChatThreadList`.Sep 12 2023, 1:57 PM

Closed by commit rCOMM22479ac32638: [native] Replace `scrollPos` instance variable w/ ref (authored by atul). · Explain WhySep 13 2023, 8:23 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM22479ac32638: [native] Replace `scrollPos` instance variable w/ ref.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

15 lines

Diff 30944

View Options

native/chat/chat-thread-list.react.js

[native] Replace `scrollPos` instance variable w/ refClosedPublicActions