Page MenuHomePhabricator
Differential D5024

[services] Rust Integration - Catch std::exception in base bidi reactor
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 4:16 AM
Unknown Object (File)
Sat, Dec 14, 6:15 AM
Unknown Object (File)
Sat, Dec 14, 6:15 AM
Unknown Object (File)
Sat, Dec 14, 6:15 AM
Unknown Object (File)
Sat, Dec 14, 6:14 AM
Unknown Object (File)
Sat, Dec 14, 6:08 AM
Unknown Object (File)
Mon, Dec 2, 10:54 AM
Unknown Object (File)
Nov 22 2024, 8:30 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
Commits
rCOMM62487114bb04: [services] Rust Integration - Catch std::exception in base bidi reactor
Summary

Depends on D5020

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Test Plan
cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:52 PM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:52 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 2 2022, 12:00 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
• karol added a child revision: D5025: [services] Rust Integration - Catch std::exception in base read reactor.
Harbormaster completed remote builds in B11812: Diff 16217.Sep 2 2022, 12:02 AM
• karol requested review of this revision.Sep 2 2022, 12:02 AM
tomek accepted this revision.Sep 5 2022, 7:23 AM
This revision is now accepted and ready to land.Sep 5 2022, 7:23 AM
tomek added inline comments.Sep 5 2022, 7:29 AM
services/lib/src/server-base-reactors/ServerBidiReactorBase.h
101

I'm not really sure. Maybe we can keep the current implementation and additionally catch just rust::Error, so that the rest of the logic isn't affected?

• karol added inline comments.Sep 6 2022, 3:42 AM
services/lib/src/server-base-reactors/ServerBidiReactorBase.h
101

The problem is that rust::Error is not visible. In the generated files, it is defined only in the source file, not in the header.

• karol updated this revision to Diff 16453.Sep 8 2022, 4:02 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMM62487114bb04: [services] Rust Integration - Catch std::exception in base bidi reactor (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM62487114bb04: [services] Rust Integration - Catch std::exception in base bidi reactor.
Harbormaster completed remote builds in B11998: Diff 16453.Sep 8 2022, 4:24 AM

Revision Contents
Changeset List

PathSize
services/
lib/
src/
server-base-reactors/
4 lines

Diff 16217

View Options

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

Loading...