Registered new message type EDIT_MESSAGE to messageTypes. Added some lines to prevent flow-typing errors in different places of the app. For now, when we process the added
message type, we ignore it.
Details
Details
Tested if app compiles and checked if everything works correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Accepting, but if what I suggested doesn't take too long might be worthwhile to update
lib/shared/messages/sidebar-source-message-spec.js | ||
---|---|---|
108–114 ↗ | (On Diff #23475) | When I was working on reactions, @tomek recommended defining a set of incompatible messages with the sidebar source. Now that we have more than two incompatible messages, now might be a good time to address this https://linear.app/comm/issue/ENG-2422/define-set-of-incompatible-message-types-for-sidebar-source |
Comment Actions
Rebase to master
lib/shared/messages/sidebar-source-message-spec.js | ||
---|---|---|
108–114 ↗ | (On Diff #23475) | Added as follow-up task to message editing |