Page MenuHomePhabricator
Differential D7544

[identity] delete user RPC
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 2:13 PM.
Tags
None
Referenced Files
F3542519: D7544.id25467.diff
Thu, Dec 26, 8:27 AM
F3542005: D7544.id25423.diff
Thu, Dec 26, 8:04 AM
F3539496: D7544.diff
Thu, Dec 26, 2:02 AM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
View All 100 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMeed2eaeb3422: [identity] delete user RPC
Summary

Depends on D7541

Test Plan

registered a new user, then successfully deleted it

Diff Detail

Repository
rCOMM Comm
Branch
identity (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Apr 19 2023, 2:13 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 2:14 PM
varun updated this revision to Diff 25423.Apr 19 2023, 2:20 PM

rebase

Harbormaster failed remote builds in B18548: Diff 25413!Apr 19 2023, 2:26 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:39 PM
Harbormaster failed remote builds in B18558: Diff 25423!
varun updated this revision to Diff 25467.Apr 20 2023, 10:15 AM

rebase

Harbormaster completed remote builds in B18591: Diff 25467.Apr 20 2023, 10:43 AM
varun requested review of this revision.Apr 20 2023, 10:43 AM
varun added a child revision: D7553: [identity] update user password.Apr 20 2023, 11:36 AM
ashoat added inline comments.Apr 21 2023, 6:03 AM
shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

Can you clarify why these are being added? Is it impossible to look up an accessToken just by itself, and we always need to include userID and deviceIDKey in order to validate it? (Guessing this is the case based on VerifyUserAccessTokenRequest)

varun added inline comments.Apr 21 2023, 11:26 AM
shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

yeah in our access token table, the primary key is user ID + device ID (ed25519 signing key)

ashoat added inline comments.Apr 21 2023, 11:58 AM
shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

Thanks!

• jon accepted this revision.Apr 24 2023, 1:08 PM
This revision is now accepted and ready to land.Apr 24 2023, 1:08 PM
Closed by commit rCOMMeed2eaeb3422: [identity] delete user RPC (authored by varun). · Explain WhyApr 24 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMeed2eaeb3422: [identity] delete user RPC.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
28 lines
4 lines
shared/
protos/
4 lines

Diff 25413

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/token.rs

Loading...
View Options

shared/protos/identity_client.proto

Loading...