[identity] move device_info creation to helper function
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:29 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMM418d7e9d3538: [identity] move device_info creation to helper function

Summary

small refactor to dedup

Depends on D7540

Test Plan

confirmed that the login and register RPCs worked the same as before

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 19 2023, 1:29 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:41 PM

Harbormaster failed remote builds in B18541: Diff 25405!

varun added a child revision: D7544: [identity] delete user RPC.Apr 19 2023, 2:13 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:37 PM

Harbormaster failed remote builds in B18557: Diff 25422!

rebase

Harbormaster completed remote builds in B18590: Diff 25466.Apr 20 2023, 10:41 AM

varun requested review of this revision.Apr 20 2023, 10:41 AM

bartek accepted this revision.Apr 21 2023, 2:39 AM

This revision is now accepted and ready to land.Apr 21 2023, 2:39 AM

Closed by commit rCOMM418d7e9d3538: [identity] move device_info creation to helper function (authored by varun). · Explain WhyApr 24 2023, 8:33 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM418d7e9d3538: [identity] move device_info creation to helper function.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

196 lines

Diff 25422

View Options

services/identity/src/database.rs

[identity] move device_info creation to helper functionClosedPublicActions