small refactor to dedup
Depends on D7540
Paths
| Differential D7541 Authored by varun on Apr 19 2023, 1:29 PM.
Details Summary small refactor to dedup Depends on D7540 Test Plan confirmed that the login and register RPCs worked the same as before
Diff Detail
Event TimelineHerald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:29 PM2023-04-19 13:29:26 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:41 PM2023-04-19 13:41:23 (UTC-7) varun added a child revision: D7544: [identity] delete user RPC.Apr 19 2023, 2:13 PM2023-04-19 14:13:59 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:37 PM2023-04-19 14:37:54 (UTC-7) Harbormaster completed remote builds in B18590: Diff 25466.Apr 20 2023, 10:41 AM2023-04-20 10:41:01 (UTC-7) This revision is now accepted and ready to land.Apr 21 2023, 2:39 AM2023-04-21 02:39:43 (UTC-7) Closed by commit rCOMM418d7e9d3538: [identity] move device_info creation to helper function (authored by varun). · Explain WhyApr 24 2023, 8:33 PM2023-04-24 20:33:58 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 25422 services/identity/src/database.rs
|
I meant that this Return is wrong, because in case of fanout it returns [Return]