Details

Reviewers

ashoat
ginsu
rohan
kamil
inka
michal

Commits

rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`

Summary

Sets "Reset to default" menu item onClick to removeUserAvatar which removes the user's avatar.

Test Plan

Works as expected. User had image avatar, now they have default emoji avatar:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 20 2023, 5:24 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 5:24 PM

atul edited the test plan for this revision. (Show Details)Jun 20 2023, 5:25 PM

Harbormaster completed remote builds in B20358: Diff 27903.Jun 20 2023, 5:42 PM

atul requested review of this revision.Jun 20 2023, 5:42 PM

atul added a child revision: D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.Jun 20 2023, 5:49 PM

atul added reviewers: rohan, kamil, inka, michal.Jun 21 2023, 4:45 PM

rohan accepted this revision.Jun 21 2023, 5:27 PM

rohan added inline comments.

web/avatars/edit-user-avatar-menu.react.js
20–23 ↗	(On Diff #27903)	You could probably use shorthand here

This revision is now accepted and ready to land.Jun 21 2023, 5:27 PM

atul added inline comments.Jun 21 2023, 6:21 PM

web/avatars/edit-user-avatar-menu.react.js
20–23 ↗	(On Diff #27903)	Thanks for catching that, will update.

rebase before addressing feedback

rebase before landing

This revision was landed with ongoing or failed builds.Jun 21 2023, 6:30 PM

Closed by commit rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.

Harbormaster completed remote builds in B20402: Diff 27973.Jun 21 2023, 6:41 PM

Harbormaster completed remote builds in B20403: Diff 27974.

[web] Add `removeUserAvatar` to `EditUserAvatarMenu`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27975

web/avatars/edit-user-avatar-menu.react.js

[web] Add `removeUserAvatar` to `EditUserAvatarMenu`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27975

web/avatars/edit-user-avatar-menu.react.js

[web] Add `removeUserAvatar` to `EditUserAvatarMenu`
ClosedPublic
Actions

Revision Contents
Changeset List