Differential D8292

[lib][native] Extract invite link url
ClosedPublic
Actions

Authored by tomek on Jun 22 2023, 7:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 15, 5:59 PM

	Unknown Object (File)
	Sat, Mar 15, 9:01 AM

	Unknown Object (File)
	Wed, Mar 12, 4:16 AM

	Unknown Object (File)
	Tue, Mar 11, 5:16 AM

	Unknown Object (File)
	Thu, Mar 6, 5:07 PM

	Unknown Object (File)
	Thu, Mar 6, 5:07 PM

	Unknown Object (File)
	Thu, Mar 6, 5:07 PM

	Unknown Object (File)
	Thu, Mar 6, 5:00 PM

Subscribers

Details

Reviewers

bartek
kamil
inka

Commits

rCOMM8f6f5f900738: [lib][native] Extract invite link url

Summary

Extract the link url to a common place so that it can be reused.

Depends on D8237

Test Plan

Check if the link is displayed correctly in both places.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jun 22 2023, 7:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 22 2023, 7:20 AM

tomek added a child revision: D8238: [web] Create link view modal.Jun 22 2023, 7:21 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 7:44 AM

Harbormaster failed remote builds in B20423: Diff 27997!

tomek requested review of this revision.Jun 23 2023, 1:38 AM

kamil accepted this revision.Jun 23 2023, 2:34 AM

This revision is now accepted and ready to land.Jun 23 2023, 2:34 AM

Harbormaster completed remote builds in B20423: Diff 27997.Jun 26 2023, 4:11 AM

Closed by commit rCOMM8f6f5f900738: [lib][native] Extract invite link url (authored by tomek). · Explain WhyJun 26 2023, 6:04 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM8f6f5f900738: [lib][native] Extract invite link url.

Revision Contents
Changeset List

Path

Size

lib/

facts/

7 lines

native/

invite-links/

manage-public-link-screen.react.js

3 lines

view-invite-links-screen.react.js

3 lines

Diff 27997

lib/facts/links.js

	.container {			.container {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	overflow: hidden;			overflow: hidden;
				max-height: 100%;
	}			}

native/invite-links/manage-public-link-screen.react.js

	.container {			.container {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	overflow: hidden;			overflow: hidden;
				max-height: 100%;
	}			}

native/invite-links/view-invite-links-screen.react.js

	.container {			.container {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	overflow: hidden;			overflow: hidden;
				max-height: 100%;
	}			}