[web] Add `ColorSelector` to `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 2:08 PM.

Details

Reviewers

ashoat
ginsu
michal
kamil
inka
rohan

Commits

rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`

Summary

Add ColorSelector to EmojiAvatarSelectionModal and hook up to pendingAvatarColor.

Depends on D8266

Test Plan

Works as expected:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 20 2023, 2:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 2:08 PM

atul published this revision for review.Jun 20 2023, 2:11 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B20369: Diff 27914.Jun 20 2023, 2:27 PM

atul added a child revision: D8268: [web] Add emoji `Picker` to `EmojiAvatarSelectionModal`.Jun 20 2023, 3:16 PM

atul added reviewers: michal, kamil, inka, rohan.Jun 21 2023, 9:46 AM

rohan accepted this revision.Jun 21 2023, 10:53 AM

This revision is now accepted and ready to land.Jun 21 2023, 10:53 AM

rebase before landing

Harbormaster failed remote builds in B20442: Diff 28024!Jun 22 2023, 2:35 PM

rebase before landing

Harbormaster completed remote builds in B20487: Diff 28073.Jun 23 2023, 1:53 PM

Closed by commit rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal` (authored by atul). · Explain WhyJun 23 2023, 2:07 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5814bc62eca6: [web] Add `ColorSelector` to `EmojiAvatarSelectionModal`.

Revision Contents
Changeset List

Path

Size

web/

avatars/

emoji-avatar-selection-modal.react.js

8 lines

Diff 28024

View Options

web/avatars/emoji-avatar-selection-modal.react.js

[web] Add `ColorSelector` to `EmojiAvatarSelectionModal`ClosedPublicActions