Page MenuHomePhabricator
Differential D8605

[Protos] Move GetKeyserverInfo to authtenticated service
ClosedPublic
Actions

Authored by • jon on Jul 24 2023, 6:50 AM.
Tags
None
Referenced Files
F3364701: D8605.id29625.diff
Mon, Nov 25, 4:44 AM
Unknown Object (File)
Sat, Nov 23, 2:36 PM
Unknown Object (File)
Sat, Nov 23, 12:53 PM
Unknown Object (File)
Sat, Nov 23, 12:53 PM
Unknown Object (File)
Sat, Nov 23, 12:53 PM
Unknown Object (File)
Sun, Oct 27, 3:42 PM
Unknown Object (File)
Oct 24 2024, 3:36 AM
Unknown Object (File)
Oct 21 2024, 2:35 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service
Summary

We should only be issuing one-time keys to authenticated
devices. Move this to the authenticated service.

Part of https://linear.app/comm/issue/ENG-4445

Depends on D7691

Test Plan

N/A. Protobuf review

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 24 2023, 6:50 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 6:50 AM
• jon added a child revision: D8606: [Identity] Refactor get user_id and device_id.Jul 24 2023, 6:52 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 6:57 AM
Harbormaster failed remote builds in B21148: Diff 28970!
• jon updated this revision to Diff 29027.Jul 25 2023, 10:42 AM

Rebase on fixes

Harbormaster completed remote builds in B21191: Diff 29027.Jul 25 2023, 10:59 AM
• jon requested review of this revision.Jul 25 2023, 10:59 AM
varun requested changes to this revision.Jul 25 2023, 2:16 PM

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

This revision now requires changes to proceed.Jul 25 2023, 2:16 PM
• jon updated this revision to Diff 29082.Jul 26 2023, 6:07 PM

Remove OutboundKeyserverResponse from identity_client.proto

• jon added a comment.Jul 26 2023, 6:07 PM

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

It can, thanks.

Harbormaster completed remote builds in B21238: Diff 29082.Jul 26 2023, 6:26 PM
varun accepted this revision.Jul 27 2023, 9:51 AM
This revision is now accepted and ready to land.Jul 27 2023, 9:51 AM
• jon removed a parent revision: D7691: [Keyserver] Open websocket connection with tunnelbroker.Aug 8 2023, 8:53 AM
Closed by commit rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service (authored by • jon). · Explain WhyAug 8 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
23 lines
grpc_services/
11 lines
shared/
protos/
27 lines
4 lines

Diff 28970

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

shared/protos/identity_authenticated.proto

Loading...
View Options

shared/protos/identity_client.proto

Loading...