[Protos] Move GetKeyserverInfo to authtenticated service
ClosedPublic
Actions

Authored by • jon on Jul 24 2023, 1:50 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service

Summary

We should only be issuing one-time keys to authenticated
devices. Move this to the authenticated service.

Part of https://linear.app/comm/issue/ENG-4445

Depends on D7691

Test Plan

N/A. Protobuf review

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 24 2023, 1:50 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 1:50 PM

• jon added a child revision: D8606: [Identity] Refactor get user_id and device_id.Jul 24 2023, 1:52 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 1:57 PM

Harbormaster failed remote builds in B21148: Diff 28970!

Rebase on fixes

Harbormaster completed remote builds in B21191: Diff 29027.Jul 25 2023, 5:59 PM

• jon requested review of this revision.Jul 25 2023, 5:59 PM

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

This revision now requires changes to proceed.Jul 25 2023, 9:16 PM

Remove OutboundKeyserverResponse from identity_client.proto

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

It can, thanks.

Harbormaster completed remote builds in B21238: Diff 29082.Jul 27 2023, 1:26 AM

varun accepted this revision.Jul 27 2023, 4:51 PM

This revision is now accepted and ready to land.Jul 27 2023, 4:51 PM

• jon removed a parent revision: D7691: [Keyserver] Open websocket connection with tunnelbroker.Aug 8 2023, 3:53 PM

Closed by commit rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service. · Explain WhyAug 8 2023, 4:00 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM2406ff73d295: [Protos] Move GetKeyserverInfo to authtenticated service.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

23 lines

grpc_services/

authenticated.rs

11 lines

shared/

protos/

identity_authenticated.proto

27 lines

identity_client.proto

4 lines

Diff 28970

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

shared/protos/identity_authenticated.proto

View Options

shared/protos/identity_client.proto

[Protos] Move GetKeyserverInfo to authtenticated serviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28970

services/identity/src/client_service.rs

services/identity/src/grpc_services/authenticated.rs

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

[Protos] Move GetKeyserverInfo to authtenticated service
ClosedPublic
Actions

Revision Contents
Changeset List