Page MenuHomePhabricator

[Identity] Refactor get user_id and device_id
ClosedPublic

Authored by jon on Jul 24 2023, 6:52 AM.
Tags
None
Referenced Files
F3346869: D8606.id29626.diff
Fri, Nov 22, 10:05 AM
F3346817: D8606.id28971.diff
Fri, Nov 22, 9:57 AM
F3343802: D8606.diff
Fri, Nov 22, 4:07 AM
Unknown Object (File)
Sun, Oct 27, 3:42 PM
Unknown Object (File)
Oct 14 2024, 9:26 AM
Unknown Object (File)
Oct 11 2024, 10:52 PM
Unknown Object (File)
Oct 7 2024, 12:37 AM
Unknown Object (File)
Oct 6 2024, 6:02 PM
Subscribers

Details

Summary

This is useful for all authenticated requests, refactor.

Part of: https://linear.app/comm/issue/ENG-4445

Depends on D8605

Test Plan
cd identity && cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 6:58 AM
Harbormaster failed remote builds in B21149: Diff 28971!
bartek added inline comments.
services/identity/src/grpc_services/authenticated.rs
73 ↗(On Diff #29028)

If they're a common pair, we can go further and define a struct type for them

This revision is now accepted and ready to land.Jul 26 2023, 3:04 AM
jon added inline comments.
services/identity/src/grpc_services/authenticated.rs
73 ↗(On Diff #29028)

A lot of these changes are just small improvements, it's hard to know when I should make something more formalized.

76 ↗(On Diff #29028)

Would probably be nice for this to be defined in some more formal way. However, that would probably involve moving a bunch of this to something in shared/

77 ↗(On Diff #29028)

this should probably be related to missing a header instead of unauthenticated, although this value is also used for authentication.