Paths

Table of Contentst

Differential D8451

[blob-service] DB: Add holder management methods
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:03 PM.

Tags

None

Referenced Files

	F3243077: D8451.id28991.diff
	Thu, Nov 14, 7:59 AM

	Unknown Object (File)
	Fri, Nov 1, 6:12 PM

	Unknown Object (File)
	Fri, Nov 1, 6:11 PM

	Unknown Object (File)
	Fri, Nov 1, 6:11 PM

	Unknown Object (File)
	Fri, Nov 1, 6:11 PM

	Unknown Object (File)
	Fri, Nov 1, 5:47 PM

	Unknown Object (File)
	Mon, Oct 28, 1:35 AM

	Unknown Object (File)
	Sun, Oct 27, 4:34 PM

Subscribers

Details

Reviewers

michal
varun
• patryk
• jon

Commits

rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods

Summary

Part of ENG-4269.

Added methods to manage holder assignments - design described in-depth in the notion doc attached to the parent linear issue

Depends on D8450.

Test Plan

Tested together with the previous and the following diff

Created a custom testing sandbox to play with these:

Checkout this stack (this + next diff)
Apply this patch and copy the tests.rs file contents attached there to the services/blob/src/database/client/tests.rs.
cargo run

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 9 2023, 2:03 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:03 PM

bartek added a child revision: D8452: [blob-service] DB: Add remaining client methods.Jul 9 2023, 2:04 PM

Harbormaster completed remote builds in B20820: Diff 28507.Jul 9 2023, 2:23 PM

bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:01 PM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Jul 10 2023, 12:43 AM

Rust looks fine to me, but would like other to take a look

michal added inline comments.Jul 11 2023, 2:22 AM

services/blob/src/database/client.rs
156–157 ↗	(On Diff #28507)	Should we create a followup task for this?
310 ↗	(On Diff #28507)	Why are we checking if len < 3? Should we maybe put it into a more descriptive constant?

varun accepted this revision.Jul 13 2023, 10:00 AM

This revision is now accepted and ready to land.Jul 13 2023, 10:00 AM

bartek added a child revision: D8453: [blob-service] Create business logic abstraction.Jul 21 2023, 1:15 AM

Rebase

Harbormaster completed remote builds in B21100: Diff 28911.Jul 21 2023, 2:21 AM

Closed by commit rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods (authored by bartek). · Explain WhyJul 25 2023, 1:44 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database/

139 lines

4 lines

Diff 28991

services/blob/src/database/client.rs

Loading...

services/blob/src/database/errors.rs

Loading...