Page MenuHomePhabricator
Differential D8606

[Identity] Refactor get user_id and device_id
ClosedPublic
Actions

Authored by • jon on Jul 24 2023, 6:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 7:06 PM
Unknown Object (File)
Sat, Dec 14, 7:06 PM
Unknown Object (File)
Sat, Dec 14, 7:06 PM
Unknown Object (File)
Sat, Dec 14, 7:06 PM
Unknown Object (File)
Sat, Dec 14, 6:59 PM
Unknown Object (File)
Fri, Dec 13, 12:52 AM
Unknown Object (File)
Fri, Dec 6, 11:51 AM
Unknown Object (File)
Mon, Nov 25, 11:18 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM9a3688162429: [Identity] Refactor get user_id and device_id
Summary

This is useful for all authenticated requests, refactor.

Part of: https://linear.app/comm/issue/ENG-4445

Depends on D8605

Test Plan
cd identity && cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 24 2023, 6:52 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 6:52 AM
• jon added a child revision: D8607: [Identity] Refactor DB error logic.Jul 24 2023, 6:54 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 6:58 AM
Harbormaster failed remote builds in B21149: Diff 28971!
• jon updated this revision to Diff 29028.Jul 25 2023, 10:42 AM

Rebase on fixes

Harbormaster completed remote builds in B21192: Diff 29028.Jul 25 2023, 11:00 AM
• jon requested review of this revision.Jul 25 2023, 11:00 AM
bartek accepted this revision.Jul 26 2023, 3:04 AM
bartek added inline comments.
services/identity/src/grpc_services/authenticated.rs
73

If they're a common pair, we can go further and define a struct type for them

This revision is now accepted and ready to land.Jul 26 2023, 3:04 AM
• jon marked an inline comment as done.Jul 26 2023, 7:38 AM
• jon added inline comments.
services/identity/src/grpc_services/authenticated.rs
73

A lot of these changes are just small improvements, it's hard to know when I should make something more formalized.

76

Would probably be nice for this to be defined in some more formal way. However, that would probably involve moving a bunch of this to something in shared/

77

this should probably be related to missing a header instead of unauthenticated, although this value is also used for authentication.

• jon marked an inline comment as done.Aug 8 2023, 8:58 AM
Closed by commit rCOMM9a3688162429: [Identity] Refactor get user_id and device_id (authored by • jon). · Explain WhyAug 8 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM9a3688162429: [Identity] Refactor get user_id and device_id.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
16 lines

Diff 29028

View Options

services/identity/src/grpc_services/authenticated.rs

Loading...