[web] Display a Roles option in the community menu
ClosedPublic
Actions

Authored by rohan on Jul 21 2023, 8:57 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMMe60afab16ca6: [web] Display a Roles option in the community menu

Summary

If the user has CHANGE_ROLE permissions, we want to allow them to see the 'Roles' option in the community actions menu. Implementation will come in the following diffs, this just gets the icon /
option shown.

ENG-4425

Depends on D8591

Test Plan

Checked that the option shows for my local admin user only

Screenshot 2023-07-21 at 11.57.40 AM.png (1×1 px, 275 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jul 21 2023, 8:57 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2023, 8:57 AM

rohan edited the test plan for this revision. (Show Details)Jul 21 2023, 8:57 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a child revision: D8593: [web] Create a community roles modal to display all roles and member counts.Jul 21 2023, 9:03 AM

Harbormaster completed remote builds in B21120: Diff 28942.Jul 21 2023, 9:14 AM

rohan requested review of this revision.Jul 21 2023, 9:14 AM

Shouldn't we add some sort of isDev check so we don't roll out this dummy button to users when a keyserver release is made?

This revision now requires changes to proceed.Jul 24 2023, 11:21 PM

In D8592#253496, @atul wrote:

Shouldn't we add some sort of isDev check so we don't roll out this dummy button to users when a keyserver release is made?

Would I need this if I'm landing the entire stack once completed all at once? I thought I'd need that only if I was landing this early before landing the rest of the web stack was done

Re-requesting review because I don't think I need it if I'm landing the entire stack at once (and so my comment doesn't get lost), but let me know if I'm missing something!

agree with @rohan that isDev check shouldn't be necessary if we are landing stack all at once

Re-requesting review because I don't think I need it if I'm landing the entire stack at once

Ah yeah not necessary if landing the whole stack at once I guess. My preference is to ensure things are landable as-is (eg put things behind isDev), but this is also fine.

This revision is now accepted and ready to land.Jul 25 2023, 11:44 PM

Rebase

This revision was landed with ongoing or failed builds.Jul 31 2023, 6:15 PM

Closed by commit rCOMMe60afab16ca6: [web] Display a Roles option in the community menu (authored by rohan). · Explain Why

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMe60afab16ca6: [web] Display a Roles option in the community menu.

Harbormaster completed remote builds in B21424: Diff 29336.Jul 31 2023, 8:24 PM