Page MenuHomePhabricator
Differential D8709

[web] deprecate stringForReactionList
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 12:09 PM.
Tags
None
Referenced Files
F3347059: D8709.diff
Fri, Nov 22, 10:56 AM
Unknown Object (File)
Sat, Nov 16, 11:17 AM
Unknown Object (File)
Fri, Nov 1, 1:22 PM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:31 AM
View All 96 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM569644b864be: [web] deprecate stringForReactionList
Summary

In D8708 we got rid of the last usage of stringForReactionList. Now that this function is no longer being used we can get rid of this funciton and the unit tests associated with this function

Depends on D8708

Test Plan

flow and did a global search of stringForReactionList to confirm that this function was not being used anywhere else in the codebase

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 2 2023, 12:09 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 12:09 PM
ginsu edited the test plan for this revision. (Show Details)Aug 2 2023, 12:10 PM
ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)Aug 2 2023, 12:13 PM
ginsu added a parent revision: D8708: [web] seperate out each reaction into their own pill.
ginsu added a child revision: D8710: [web] make reactions prop for InlineEngagement requried.Aug 2 2023, 12:20 PM
ginsu published this revision for review.Aug 2 2023, 12:25 PM
Harbormaster failed remote builds in B21497: Diff 29491!Aug 2 2023, 1:45 PM
atul accepted this revision.Aug 3 2023, 4:57 AM
This revision is now accepted and ready to land.Aug 3 2023, 4:57 AM
ginsu updated this revision to Diff 30364.Aug 27 2023, 7:49 PM

rebase before landing

Harbormaster completed remote builds in B22130: Diff 30364.Aug 27 2023, 8:06 PM
Closed by commit rCOMM569644b864be: [web] deprecate stringForReactionList (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM569644b864be: [web] deprecate stringForReactionList.

Revision Contents
Changeset List

PathSize
lib/
shared/
18 lines

Diff 29491

View Options

lib/shared/reaction-utils.js

Loading...
View Options

lib/shared/reaction-utils.test.js

Loading...