[Identity] Allow for tunnelbroker endpoint to be configured
ClosedPublic
Actions

Authored by • jon on Aug 3 2023, 10:35 AM.

Details

Reviewers

bartek
varun

Commits

rCOMMcc457d50583f: [Identity] Allow for tunnelbroker endpoint to be configured

Summary

Identity service needs some way to communicate with tunnelbroker
when issueing device requests. Currently this is limited to just
"refresh onetime keys", however, will likely include more messages in the
future.

https://linear.app/comm/issue/ENG-4583

Depends on D8722

Test Plan

cd services/identity
cargo run -- server
# Should see output that it's falling back to localhost

export TUNNELBROKER_GRPC_ENDPOINT=https://tunnelbroker.staging.commtechnologies.org:50051
cargo run -- server
# Should see output that it's now using the other endpoint

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/keyserver-tunnelbroker (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 3 2023, 10:35 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 3 2023, 10:35 AM

Harbormaster completed remote builds in B21520: Diff 29517.Aug 3 2023, 12:21 PM

• jon requested review of this revision.Aug 3 2023, 12:21 PM

Looks good, another (perhaps more idiomatic) way would be to extend the clap config for server subcommand and using the #[arg(env = TUNNELBROKER_GRPC_ENDPOINT)] to give env var config possibility. However, other options would need to be migrated as well (localstack endpoint, keyserver public key etc) so definitely not a purpose of this diff, rather a follow-up.

This revision is now accepted and ready to land.Aug 4 2023, 2:37 AM

• jon added a child revision: D8748: [Identity] Issue refresh_key_request to tunnelbroker.Aug 7 2023, 7:51 AM

Rebase on changes

Harbormaster completed remote builds in B21684: Diff 29803.Aug 9 2023, 5:49 PM

Rebase on master

Harbormaster completed remote builds in B21856: Diff 30030.Aug 17 2023, 10:43 AM

Closed by commit rCOMMcc457d50583f: [Identity] Allow for tunnelbroker endpoint to be configured (authored by • jon). · Explain WhyAug 20 2023, 11:40 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMcc457d50583f: [Identity] Allow for tunnelbroker endpoint to be configured.