Page MenuHomePhabricator
Differential D8826

[web] rename getMessageActionTooltipStyle to getTooltipStyle
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 2:00 PM
Unknown Object (File)
Fri, Apr 18, 11:56 AM
Unknown Object (File)
Fri, Apr 18, 8:45 AM
Unknown Object (File)
Thu, Apr 17, 10:12 AM
Unknown Object (File)
Sat, Mar 29, 9:38 PM
Unknown Object (File)
Mar 23 2025, 12:58 PM
Unknown Object (File)
Mar 17 2025, 4:46 PM
Unknown Object (File)
Mar 17 2025, 4:46 PM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle
Summary

simple rename diff since the functionality of this function can be used for any tooltip not just the message action tooltip

Depends on D8819

Test Plan

flow and confirmed that there were no regressions with the web message tooltip

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 15 2023, 11:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 11:37 PM
ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 11:38 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8819: [web] introduce ReactionPill component.
ginsu added a child revision: D8827: [web] convert createTooltip to getTooltipPositionStyle.Aug 15 2023, 11:44 PM
Harbormaster completed remote builds in B21779: Diff 29933.Aug 15 2023, 11:55 PM
ginsu requested review of this revision.Aug 15 2023, 11:55 PM
kamil accepted this revision.Aug 16 2023, 2:29 AM
This revision is now accepted and ready to land.Aug 16 2023, 2:29 AM
ginsu updated this revision to Diff 30383.Aug 27 2023, 8:55 PM

rebase before landing

Harbormaster completed remote builds in B22137: Diff 30383.Aug 27 2023, 9:11 PM
Closed by commit rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle.

Revision Contents
Changeset List

PathSize
web/
utils/
4 lines
12 lines

Diff 29933

View Options

web/utils/tooltip-action-utils.js

Loading...
View Options

web/utils/tooltip-utils.js

Loading...