Page MenuHomePhabricator
Differential D8721

[Identity] Add some utilties with manipulating DDB results
ClosedPublic
Actions

Authored by • jon on Aug 3 2023, 9:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:51 AM
Unknown Object (File)
Sat, Dec 14, 7:07 PM
Unknown Object (File)
Sat, Dec 14, 7:07 PM
Unknown Object (File)
Sat, Dec 14, 7:07 PM
Unknown Object (File)
Sat, Dec 14, 7:07 PM
Unknown Object (File)
Sat, Dec 14, 7:06 PM
Unknown Object (File)
Sat, Dec 14, 6:59 PM
Unknown Object (File)
Mon, Nov 25, 3:01 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMc107c9ad68bc: [Identity] Add some utilties with manipulating DDB results
Summary

Refactored some common logic into utils file. This is
commonly used in the next diff.

https://linear.app/comm/issue/ENG-4582

Depends on D8675

Test Plan
cd services/identity
cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 3 2023, 9:49 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 3 2023, 9:49 AM
• jon added a child revision: D8722: [Identity] Implement GetKeyserverKeys.Aug 3 2023, 9:59 AM
Harbormaster completed remote builds in B21517: Diff 29514.Aug 3 2023, 12:11 PM
• jon requested review of this revision.Aug 3 2023, 12:11 PM
bartek accepted this revision.Aug 4 2023, 12:22 AM

I see that it was impossible to use TryFrom / TryInto traits because of the need to pass attribute names.

I wish that we could put it in comm-services-lib but aws-sdk-* versions mismatch again 😖

This revision is now accepted and ready to land.Aug 4 2023, 12:22 AM
• jon updated this revision to Diff 29883.Aug 15 2023, 7:20 AM

Propagate onetime -> one-time changes

Harbormaster completed remote builds in B21744: Diff 29883.Aug 15 2023, 7:38 AM
• jon updated this revision to Diff 30029.Aug 17 2023, 10:25 AM

Rebase on master

Harbormaster completed remote builds in B21855: Diff 30029.Aug 17 2023, 10:43 AM
• jon mentioned this in D8761: [identity] db method to get inbound keys for user.Aug 18 2023, 1:31 PM
• jon mentioned this in D8765: [identity] more helpers for identity service.
Closed by commit rCOMMc107c9ad68bc: [Identity] Add some utilties with manipulating DDB results (authored by • jon). · Explain WhyAug 20 2023, 10:24 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMc107c9ad68bc: [Identity] Add some utilties with manipulating DDB results.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
identity/
6 lines
tests/
85 lines
identity/
src/
212 lines
2 lines
88 lines
grpc_services/
37 lines

Diff 30029

View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/tests/identity_keyserver_tests.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/ddb_utils.rs

Loading...
View Options

services/identity/src/error.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...