Page MenuHomePhabricator
Differential D8858

[web] rename calculateToolTipSize to calculateMessageTooltipSize
ClosedPublic
Actions

Authored by ginsu on Aug 17 2023, 5:59 PM.
Tags
None
Referenced Files
F2135247: D8858.diff
Fri, Jun 28, 10:32 AM
Unknown Object (File)
Thu, Jun 27, 1:19 AM
Unknown Object (File)
Tue, Jun 25, 11:29 PM
Unknown Object (File)
Sun, Jun 23, 4:54 AM
Unknown Object (File)
Sat, Jun 22, 2:58 AM
Unknown Object (File)
Thu, Jun 20, 8:55 AM
Unknown Object (File)
Thu, Jun 20, 4:58 AM
Unknown Object (File)
Thu, Jun 13, 6:25 PM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize
Summary

this function calculates the size of the message tooltip so calculateMessageTooltipSize is a more accurate name

Depends on D8823

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 17 2023, 5:59 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 5:59 PM
ginsu edited the summary of this revision. (Show Details)Aug 17 2023, 6:00 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8823: [web] introduce ReactionTooltip component.
Harbormaster completed remote builds in B21872: Diff 30050.Aug 17 2023, 6:20 PM
ginsu requested review of this revision.Aug 17 2023, 6:20 PM
ginsu added a child revision: D8857: [web] introduce calculateReactionTooltipSize function.Aug 17 2023, 6:28 PM
kamil accepted this revision.Aug 24 2023, 1:51 PM
This revision is now accepted and ready to land.Aug 24 2023, 1:51 PM
ginsu updated this revision to Diff 30390.Aug 27 2023, 9:03 PM

rebase before landing

Harbormaster completed remote builds in B22144: Diff 30390.Aug 27 2023, 9:20 PM
Closed by commit rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize.

Revision Contents
Changeset List

PathSize
web/
utils/
4 lines
15 lines

Diff 30050

View Options

web/utils/tooltip-action-utils.js

Loading...
View Options

web/utils/tooltip-utils.js

Loading...