Page MenuHomePhabricator
Differential D8859

[web] introduce useReactionTooltip hook
ClosedPublic
Actions

Authored by ginsu on Aug 17 2023, 6:33 PM.
Tags
None
Referenced Files
F3348828: D8859.id30053.diff
Fri, Nov 22, 4:09 PM
F3347090: D8859.diff
Fri, Nov 22, 11:06 AM
Unknown Object (File)
Sun, Nov 10, 3:09 PM
Unknown Object (File)
Mon, Oct 28, 6:41 AM
Unknown Object (File)
Mon, Oct 28, 6:41 AM
Unknown Object (File)
Mon, Oct 28, 6:41 AM
Unknown Object (File)
Mon, Oct 28, 6:41 AM
Unknown Object (File)
Mon, Oct 28, 6:39 AM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM7c47bc1c71ab: [web] introduce useReactionTooltip hook
Summary

This hooks runs all the logic necessary to create the reaction tooltip, and returns the onMouseEnter and onMouseLeave callbacks to be forwarded to the ReactionPill

Linear task: https://linear.app/comm/issue/ENG-3105/introduce-a-new-pop-up-component-that-renders-everytime-a-users-mouse

Depends on D8857

Test Plan

Please see the demo video below

above:

below (not the default position, but just changed it for testing purposes):

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 17 2023, 6:33 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 6:33 PM
ginsu edited the summary of this revision. (Show Details)Aug 17 2023, 6:39 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8857: [web] introduce calculateReactionTooltipSize function.
ginsu attached a referenced file: F694635: Screen Recording 2023-08-17 at 9.37.06 PM.mov. (Show Details)
ginsu attached a referenced file: F694639: Screen Recording 2023-08-17 at 1.28.37 PM.mov. (Show Details)
Harbormaster completed remote builds in B21875: Diff 30053.Aug 17 2023, 6:51 PM
ginsu requested review of this revision.Aug 17 2023, 6:51 PM
ginsu added a child revision: D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.Aug 17 2023, 6:56 PM
ashoat added a comment.Aug 18 2023, 3:49 PM

Nit

web/utils/tooltip-action-utils.js
472–475

Since this is always the same object, it would help to define it in the top-level scope, so it doesn't get recreated every time

kamil accepted this revision.Aug 24 2023, 2:12 PM
kamil added inline comments.
web/utils/tooltip-action-utils.js
468
479–484
This revision is now accepted and ready to land.Aug 24 2023, 2:12 PM
kamil mentioned this in D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.Aug 24 2023, 2:39 PM
ginsu updated this revision to Diff 30392.Aug 27 2023, 9:17 PM

address comments / rebase before landing

Harbormaster completed remote builds in B22146: Diff 30392.Aug 27 2023, 9:33 PM
Closed by commit rCOMM7c47bc1c71ab: [web] introduce useReactionTooltip hook (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7c47bc1c71ab: [web] introduce useReactionTooltip hook.

Revision Contents
Changeset List

PathSize
web/
chat/
21 lines
utils/
55 lines

Diff 30053

View Options

web/chat/reaction-pill.react.js

Loading...
View Options

web/utils/tooltip-action-utils.js

Loading...