Page MenuHomePhabricator
Differential D8890

[gRPC_Clients] Add tunnelbroker client
ClosedPublic
Actions

Authored by • jon on Aug 21 2023, 6:57 AM.
Tags
None
Referenced Files
F3341671: D8890.diff
Thu, Nov 21, 11:23 PM
Unknown Object (File)
Tue, Oct 29, 3:53 PM
Unknown Object (File)
Mon, Oct 28, 11:27 PM
Unknown Object (File)
Sun, Oct 27, 3:19 AM
Unknown Object (File)
Sun, Oct 27, 3:19 AM
Unknown Object (File)
Sun, Oct 27, 3:19 AM
Unknown Object (File)
Sun, Oct 27, 3:19 AM
Unknown Object (File)
Sun, Oct 27, 3:17 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM7aa7ce21abe9: [gRPC_Clients] Add tunnelbroker client
Summary

Add tunnelbroker client to grpc_clients crate.

Part of https://linear.app/comm/issue/ENG-4641

Depends on D8878

Test Plan
cd shared/grpc_clients
cargo build

This will be used in a later diff to test correctness

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 21 2023, 6:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 21 2023, 6:57 AM
• jon added a child revision: D8891: [Identity] Adopt TLS-enabled tunnelbroker client.Aug 21 2023, 6:59 AM
Harbormaster completed remote builds in B21946: Diff 30143.Aug 21 2023, 7:16 AM
• jon requested review of this revision.Aug 21 2023, 7:16 AM
bartek accepted this revision.Aug 22 2023, 12:30 AM
bartek added inline comments.
shared/grpc_clients/src/lib.rs
31 ↗(On Diff #30143)

It's no longer identity-specific

This revision is now accepted and ready to land.Aug 22 2023, 12:30 AM
• jon updated this revision to Diff 30342.Aug 25 2023, 4:53 PM

Rebase on top of master

Harbormaster completed remote builds in B22108: Diff 30342.Aug 25 2023, 5:11 PM
• jon updated this revision to Diff 30412.Aug 27 2023, 10:44 PM

Make less specific than just identity service

• jon marked an inline comment as done.Aug 27 2023, 10:45 PM
• jon added inline comments.
shared/grpc_clients/src/lib.rs
31 ↗(On Diff #30143)

Thanks

Harbormaster completed remote builds in B22153: Diff 30412.Aug 27 2023, 11:01 PM
Closed by commit rCOMM7aa7ce21abe9: [gRPC_Clients] Add tunnelbroker client (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM
This revision was automatically updated to reflect the committed changes.
• jon marked an inline comment as done.
• jon added a commit: rCOMM7aa7ce21abe9: [gRPC_Clients] Add tunnelbroker client.

Revision Contents
Changeset List

PathSize
shared/
grpc_clients/
1 line
src/
identity/
4 lines
23 lines
2 lines
21 lines
tunnelbroker/
14 lines

Diff 30342

View Options

shared/grpc_clients/build.rs

Loading...
View Options

shared/grpc_clients/src/identity/authenticated.rs

Loading...
View Options

shared/grpc_clients/src/identity/mod.rs

Loading...
View Options

shared/grpc_clients/src/identity/unauthenticated.rs

Loading...
View Options

shared/grpc_clients/src/lib.rs

Loading...
View Options

shared/grpc_clients/src/tunnelbroker/mod.rs

Loading...