Page MenuHomePhabricator
Differential D8678

[web] split the inline engagement pill into two
ClosedPublic
Actions

Authored by ginsu on Jul 31 2023, 7:22 AM.
Tags
None
Referenced Files
F3368943: D8678.diff
Mon, Nov 25, 9:13 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Fri, Nov 22, 4:34 PM
Unknown Object (File)
Fri, Nov 22, 3:06 PM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM51232ff99e7a: [web] split the inline engagement pill into two
Summary

As a first step to redesigning the InlineEngagement component we should split the sidebar and the reactions into two separate pills.

This diff and subsequent diffs won't be landed until the rest of the web inline engagement work is completed

Depends on D8677

Test Plan

Please look at the screenshots below:

Before:

Screenshot 2023-07-31 at 10.24.06 AM.png (1×3 px, 1 MB)

After:

Screenshot 2023-07-31 at 10.20.47 AM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 31 2023, 7:22 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 31 2023, 7:22 AM
ginsu edited the summary of this revision. (Show Details)Jul 31 2023, 7:24 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8677: [web] clean up InlineEngagement component.
ginsu attached a referenced file: F667135: Screenshot 2023-07-31 at 10.20.47 AM.png. (Show Details)
ginsu attached a referenced file: F667136: Screenshot 2023-07-31 at 10.24.06 AM.png. (Show Details)
ginsu published this revision for review.Jul 31 2023, 7:27 AM
Harbormaster completed remote builds in B21372: Diff 29276.Jul 31 2023, 8:58 AM
ginsu added a child revision: D8684: [web] clean up edited label.Jul 31 2023, 11:25 AM
atul accepted this revision.Aug 1 2023, 2:12 PM

Don't love the way the "after" looks, but guessing this is an intermediate step "on the way" to the intended design?

This revision is now accepted and ready to land.Aug 1 2023, 2:12 PM
ginsu added a comment.Aug 2 2023, 9:11 AM

Don't love the way the "after" looks, but guessing this is an intermediate step "on the way" to the intended design?

Yes this is an intermediate step, and we will eventually have something that looks like this:

Screenshot 2023-08-02 at 12.10.33 PM.png (2×3 px, 1 MB)

ginsu attached a referenced file: F672139: Screenshot 2023-08-02 at 12.10.33 PM.png. (Show Details)Aug 2 2023, 9:11 AM
ginsu updated this revision to Diff 30360.Aug 27 2023, 7:45 PM

rebase before landing

Harbormaster completed remote builds in B22126: Diff 30360.Aug 27 2023, 8:04 PM
Closed by commit rCOMM51232ff99e7a: [web] split the inline engagement pill into two (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM51232ff99e7a: [web] split the inline engagement pill into two.

Revision Contents
Changeset List

PathSize
web/
chat/
25 lines
20 lines

Diff 30372

View Options

web/chat/inline-engagement.css

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...