[web] clean up edited label
ClosedPublic
Actions

Authored by ginsu on Jul 31 2023, 11:22 AM.

Details

Reviewers

atul
kamil

Commits

rCOMM1e7c476d9438: [web] clean up edited label

Summary

Small cleanup diff which simplifies the logic around the editedLabel and always makes the structure of the web InlineEngagement component symmetrical to the native InlineEngagement component

Depends on D8678

Test Plan

flow and confirmed that there were no regresions with the web InlineEngagement

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 31 2023, 11:22 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 31 2023, 11:22 AM

ginsu edited the summary of this revision. (Show Details)Jul 31 2023, 11:25 AM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8678: [web] split the inline engagement pill into two.

ginsu published this revision for review.Jul 31 2023, 11:50 AM

Harbormaster completed remote builds in B21386: Diff 29298.Jul 31 2023, 12:10 PM

atul accepted this revision.Aug 1 2023, 2:16 PM

atul added inline comments.

web/chat/inline-engagement.css
54 ↗	(On Diff #29298)	Thanks for annotating this! I think this sort of note will help prevent subtle layout/styling regressions in the future
web/chat/inline-engagement.react.js
28 ↗	(On Diff #29298)	I'd maybe just inline this within the call to `classNames`, totally arbitrary and personal preference so up to you