Details

Reviewers

atul
kamil

Commits

rCOMM7c47bc1c71ab: [web] introduce useReactionTooltip hook

Summary

This hooks runs all the logic necessary to create the reaction tooltip, and returns the onMouseEnter and onMouseLeave callbacks to be forwarded to the ReactionPill

Linear task: https://linear.app/comm/issue/ENG-3105/introduce-a-new-pop-up-component-that-renders-everytime-a-users-mouse

Depends on D8857

Test Plan

Please see the demo video below

above:

below (not the default position, but just changed it for testing purposes):

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 17 2023, 6:33 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 6:33 PM

ginsu edited the summary of this revision. (Show Details)Aug 17 2023, 6:39 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8857: [web] introduce calculateReactionTooltipSize function.

ginsu attached a referenced file: F694635: Screen Recording 2023-08-17 at 9.37.06 PM.mov. (Show Details)

ginsu attached a referenced file: F694639: Screen Recording 2023-08-17 at 1.28.37 PM.mov. (Show Details)

Harbormaster completed remote builds in B21875: Diff 30053.Aug 17 2023, 6:51 PM

ginsu requested review of this revision.Aug 17 2023, 6:51 PM

ginsu added a child revision: D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.Aug 17 2023, 6:56 PM

Nit

web/utils/tooltip-action-utils.js
472–475 ↗	(On Diff #30053)	Since this is always the same object, it would help to define it in the top-level scope, so it doesn't get recreated every time