[Identity] Show consumed capacity when running query
ClosedPublic
Actions

Authored by • jon on Aug 20 2023, 11:32 PM.

Details

Reviewers

bartek
varun

Commits

rCOMMd5c0e5cf5ea7: [Identity] Show consumed capacity when running query

Summary

Follow up from https://phab.comm.dev/D8722#inline-56482

Depends on D8817

Test Plan

Start identity service, tunnelbroker

cd services/commtest
cargo test --test identity_keyserver_tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 20 2023, 11:32 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 20 2023, 11:32 PM

Harbormaster completed remote builds in B21930: Diff 30119.Aug 20 2023, 11:51 PM

• jon requested review of this revision.Aug 20 2023, 11:51 PM

• jon added a child revision: D8890: [gRPC_Clients] Add tunnelbroker client.Aug 21 2023, 6:57 AM

bartek accepted this revision.Aug 22 2023, 12:28 AM

bartek added inline comments.

services/identity/src/database.rs
488 ↗	(On Diff #30119)	The `info!` will probably spam the log too much when there's traffic. I'd lower it to debug/trace and just opt-in displaying debug logs when necessary

This revision is now accepted and ready to land.Aug 22 2023, 12:28 AM

Rebase on top of master

Harbormaster completed remote builds in B22107: Diff 30341.Aug 25 2023, 5:10 PM

Use debug! for read capacity

• jon marked an inline comment as done.Aug 27 2023, 10:42 PM

Harbormaster completed remote builds in B22152: Diff 30411.Aug 27 2023, 11:00 PM

Closed by commit rCOMMd5c0e5cf5ea7: [Identity] Show consumed capacity when running query (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMd5c0e5cf5ea7: [Identity] Show consumed capacity when running query.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

10 lines

Diff 30411

View Options

services/identity/src/database.rs

[Identity] Show consumed capacity when running queryClosedPublicActions