Differential D9004

[client-backup] add restore test
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 5, 12:07 AM

	Unknown Object (File)
	Wed, Mar 26, 1:42 PM

	Unknown Object (File)
	Wed, Mar 26, 1:42 PM

	Unknown Object (File)
	Wed, Mar 26, 1:42 PM

	Unknown Object (File)
	Wed, Mar 26, 1:42 PM

	Unknown Object (File)
	Wed, Mar 26, 1:42 PM

	Unknown Object (File)
	Wed, Mar 26, 1:41 PM

	Unknown Object (File)
	Sun, Mar 16, 11:25 PM

Subscribers

Details

Reviewers

michal
marcin
bartek
inka

Commits

rCOMMcab2dcdac59b: [client-backup] add restore test

Summary

We can do it automatically, but I don't want to slow the app more. Result should be presented in Alert.

Depends on D9003

Test Plan

Test both successful and failed restore.

image.png (802×394 px, 62 KB)

image.png (806×401 px, 121 KB)

image.png (803×392 px, 99 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 29 2023, 2:54 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:54 AM

Harbormaster failed remote builds in B22207: Diff 30483!Aug 29 2023, 3:04 AM

kamil edited the test plan for this revision. (Show Details)Aug 29 2023, 3:32 AM

CI

kamil published this revision for review.Aug 29 2023, 4:06 AM

Harbormaster completed remote builds in B22211: Diff 30487.Aug 29 2023, 4:07 AM

kamil planned changes to this revision.Aug 29 2023, 6:58 AM

move code to Backup Menu

kamil edited parent revisions, added: D9011: [client-backup] add backup menu screen; removed: D9003: [client-backup] implement backup handler.Aug 29 2023, 7:39 AM

kamil edited the test plan for this revision. (Show Details)Aug 29 2023, 7:41 AM

kamil added a parent revision: D9003: [client-backup] implement backup handler.

Harbormaster failed remote builds in B22226: Diff 30502!Aug 29 2023, 7:49 AM

kamil removed a parent revision: D9003: [client-backup] implement backup handler.Aug 29 2023, 7:51 AM

CI

kamil removed a parent revision: D9003: [client-backup] implement backup handler.Aug 29 2023, 7:55 AM

Harbormaster completed remote builds in B22227: Diff 30503.Aug 29 2023, 8:12 AM

kamil added reviewers: bartek, inka.Aug 29 2023, 8:39 AM

inka accepted this revision.Aug 30 2023, 12:22 AM

This revision is now accepted and ready to land.Aug 30 2023, 12:22 AM

rebase

kamil removed a parent revision: D9003: [client-backup] implement backup handler.Sep 4 2023, 3:14 AM

Harbormaster completed remote builds in B22370: Diff 30737.Sep 4 2023, 3:31 AM

Closed by commit rCOMMcab2dcdac59b: [client-backup] add restore test (authored by kamil). · Explain WhySep 5 2023, 5:13 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcab2dcdac59b: [client-backup] add restore test.

Revision Contents
Changeset List

Path

Size

native/

profile/

backup-menu.react.js

46 lines

Diff 30502

native/profile/backup-menu.react.js

	Show All 20 Lines
	import {			import {
	useServerCall,			useServerCall,
	useDispatchActionPromise,			useDispatchActionPromise,
	} from 'lib/utils/action-utils';			} from 'lib/utils/action-utils';

	import MenuItem from '../components/menu-item.react';			import MenuItem from '../components/menu-item.react';
	import Menu from '../components/menu.react';			import Menu from '../components/menu.react';
	import SidebarListModal from '../modals/chat/sidebar-list-modal.react';			import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
				import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
	import { useModalContext } from '../modals/modal-provider.react';			import { useModalContext } from '../modals/modal-provider.react';
	import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';			import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
	import ThreadMembersModal from '../modals/threads/members/members-modal.react';			import ThreadMembersModal from '../modals/threads/members/members-modal.react';
	import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';			import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
	import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';			import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
	import { useSelector } from '../redux/redux-utils';			import { useSelector } from '../redux/redux-utils';
	import SWMansionIcon from '../SWMansionIcon.react';			import SWMansionIcon from '../SWMansionIcon.react';
	import css from './thread-menu.css';			import css from './thread-menu.css';
	▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines		return (
	text="Leave Thread"			text="Leave Thread"
	icon="logout"			icon="logout"
	dangerous			dangerous
	onClick={onClickLeaveThread}			onClick={onClickLeaveThread}
	/>			/>
	);			);
	}, [onClickLeaveThread, threadInfo]);			}, [onClickLeaveThread, threadInfo]);

				const onClickPromoteSidebarToThread = React.useCallback(
				() =>
				pushModal(
				<SidebarPromoteModal
				threadInfo={threadInfo}
				onClose={popModal}
				onConfirm={onPromoteSidebar}
				/>,
				),
				[pushModal, threadInfo, popModal, onPromoteSidebar],
				);

	const promoteSidebar = React.useMemo(() => {			const promoteSidebar = React.useMemo(() => {
	return (			return (
	<MenuItem			<MenuItem
	key="promote"			key="promote"
	text="Promote Thread"			text="Promote Thread"
	icon="message-square-lines"			icon="message-square-lines"
	onClick={onPromoteSidebar}			onClick={onClickPromoteSidebarToThread}
	/>			/>
	);			);
	}, [onPromoteSidebar]);			}, [onClickPromoteSidebarToThread]);

	const menuItems = React.useMemo(() => {			const menuItems = React.useMemo(() => {
	const notificationsItem = (			const notificationsItem = (
	<MenuItem key="notifications" text="Notifications" icon="bell" />			<MenuItem key="notifications" text="Notifications" icon="bell" />
	);			);
	const separator = <hr key="separator" className={css.separator} />;			const separator = <hr key="separator" className={css.separator} />;

	// TODO: Enable menu items when the modals are implemented			// TODO: Enable menu items when the modals are implemented
	Show All 33 Lines