Page MenuHomePhabricator
Differential D8750

[Keyserver/rust] Implement upload_one_time_keys to identity service
ClosedPublic
Actions

Authored by kamil on Aug 7 2023, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 11:14 PM
Unknown Object (File)
Wed, Mar 12, 12:57 AM
Unknown Object (File)
Fri, Mar 7, 1:12 AM
Unknown Object (File)
Thu, Mar 6, 7:07 AM
Unknown Object (File)
Wed, Mar 5, 8:43 AM
Unknown Object (File)
Tue, Mar 4, 7:35 AM
Unknown Object (File)
Tue, Mar 4, 7:35 AM
Unknown Object (File)
Tue, Mar 4, 7:35 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
• jon
Commits
rCOMMd1359c5f69df: [Keyserver/rust] Implement upload_one_time_keys to identity service
Summary

Allow for the rust node addon to upload keys to identity
service.

https://linear.app/comm/issue/ENG-4601

Depends on D8749

Test Plan

Tested end-to-end in later diff

cd keyserver/addons/rust-node-addon
yarn build

Diff Detail

Repository
rCOMM Comm
Branch
keyserver-tunnelbroker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 7 2023, 8:03 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 7 2023, 8:03 AM
Harbormaster completed remote builds in B21565: Diff 29586.Aug 7 2023, 8:20 AM
• jon requested review of this revision.Aug 7 2023, 8:20 AM
• jon added a child revision: D8751: [Keyserver] Refactor getOneTimeKeyValues.Aug 7 2023, 8:21 AM
• jon removed a parent revision: D8749: [Identity/Tunnelbroker] Add integration tests.Aug 8 2023, 8:54 AM
• jon added a parent revision: D7691: [Keyserver] Open websocket connection with tunnelbroker.
bartek accepted this revision.Aug 8 2023, 10:04 AM
This revision is now accepted and ready to land.Aug 8 2023, 10:04 AM
• jon added inline comments.Aug 8 2023, 10:34 AM
keyserver/addons/rust-node-addon/src/identity_client/upload_one_time_keys.rs
19 ↗(On Diff #29586)
kamil commandeered this revision.Sep 8 2023, 7:28 AM
kamil added a reviewer: • jon.
kamil updated this revision to Diff 30866.Sep 8 2023, 7:28 AM
kamil added a parent revision: D8749: [Identity/Tunnelbroker] Add integration tests.
  • rebase
  • update comment
kamil removed a parent revision: D8749: [Identity/Tunnelbroker] Add integration tests.Sep 8 2023, 7:29 AM
Harbormaster completed remote builds in B22449: Diff 30866.Sep 8 2023, 7:46 AM
kamil updated this revision to Diff 30956.Sep 12 2023, 3:17 AM
kamil added a parent revision: D8749: [Identity/Tunnelbroker] Add integration tests.

rebase

Harbormaster failed remote builds in B22519: Diff 30956!Sep 12 2023, 3:32 AM
kamil updated this revision to Diff 31033.Sep 13 2023, 5:58 AM

rebase before landing

Harbormaster completed remote builds in B22580: Diff 31033.Sep 13 2023, 6:16 AM
Closed by commit rCOMMd1359c5f69df: [Keyserver/rust] Implement upload_one_time_keys to identity service (authored by • jon, committed by kamil). · Explain WhySep 13 2023, 6:43 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd1359c5f69df: [Keyserver/rust] Implement upload_one_time_keys to identity service.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
7 lines
src/
identity_client/
1 line
40 lines

Diff 30866

View Options

keyserver/addons/rust-node-addon/rust-binding-types.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { ChevronRight } from 'react-feather';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { threadIsPending } from 'lib/shared/thread-utils.js'; import { threadIsPending } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import { pinnedMessageCountText } from 'lib/utils/message-pinning-utils.js';
import PinnedMessagesBanner from './pinned-messages-banner.react.js';
import ThreadMenu from './thread-menu.react.js'; import ThreadMenu from './thread-menu.react.js';
import css from './thread-top-bar.css'; import css from './thread-top-bar.css';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
import Button from '../components/button.react.js'; import Button from '../components/button.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import PinnedMessagesModal from '../modals/chat/pinned-messages-modal.react.js';
import MessageSearchModal from '../modals/search/message-search-modal.react.js'; import MessageSearchModal from '../modals/search/message-search-modal.react.js';
type ThreadTopBarProps = { type ThreadTopBarProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadTopBar(props: ThreadTopBarProps): React.Node { function ThreadTopBar(props: ThreadTopBarProps): React.Node {
const { threadInfo } = props; const { threadInfo } = props;
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
let threadMenu = null; let threadMenu = null;
if (!threadIsPending(threadInfo.id)) { if (!threadIsPending(threadInfo.id)) {
threadMenu = <ThreadMenu threadInfo={threadInfo} />; threadMenu = <ThreadMenu threadInfo={threadInfo} />;
} }
const bannerText =
!!threadInfo.pinnedCount && pinnedMessageCountText(threadInfo.pinnedCount);
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const pushThreadPinsModal = React.useCallback(() => {
pushModal(
<InputStateContext.Provider value={inputState}>
<PinnedMessagesModal threadInfo={threadInfo} />
</InputStateContext.Provider>,
);
}, [pushModal, inputState, threadInfo]);
const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) {
return null;
}
return (
<div className={css.pinnedCountBanner}>
<a className={css.pinnedCountText} onClick={pushThreadPinsModal}>
{bannerText}
<ChevronRight size={14} className={css.chevronRight} />
</a>
</div>
);
}, [bannerText, pushThreadPinsModal]);
const onClickSearch = React.useCallback( const onClickSearch = React.useCallback(
() => () =>
pushModal( pushModal(
<InputStateContext.Provider value={inputState}> <InputStateContext.Provider value={inputState}>
<MessageSearchModal threadInfo={threadInfo} /> <MessageSearchModal threadInfo={threadInfo} />
</InputStateContext.Provider>, </InputStateContext.Provider>,
), ),
Show All 15 Lines <>
size={24} size={24}
icon="search" icon="search"
className={css.searchButtonIcon} className={css.searchButtonIcon}
/> />
</Button> </Button>
{threadMenu} {threadMenu}
</div> </div>
</div> </div>
{pinnedCountBanner} <PinnedMessagesBanner threadInfo={threadInfo} />
</> </>
); );
} }
export default ThreadTopBar; export default ThreadTopBar;
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { ChevronRight } from 'react-feather';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { threadIsPending } from 'lib/shared/thread-utils.js'; import { threadIsPending } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import { pinnedMessageCountText } from 'lib/utils/message-pinning-utils.js';
import PinnedMessagesBanner from './pinned-messages-banner.react.js';
import ThreadMenu from './thread-menu.react.js'; import ThreadMenu from './thread-menu.react.js';
import css from './thread-top-bar.css'; import css from './thread-top-bar.css';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
import Button from '../components/button.react.js'; import Button from '../components/button.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import PinnedMessagesModal from '../modals/chat/pinned-messages-modal.react.js';
import MessageSearchModal from '../modals/search/message-search-modal.react.js'; import MessageSearchModal from '../modals/search/message-search-modal.react.js';
type ThreadTopBarProps = { type ThreadTopBarProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadTopBar(props: ThreadTopBarProps): React.Node { function ThreadTopBar(props: ThreadTopBarProps): React.Node {
const { threadInfo } = props; const { threadInfo } = props;
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
let threadMenu = null; let threadMenu = null;
if (!threadIsPending(threadInfo.id)) { if (!threadIsPending(threadInfo.id)) {
threadMenu = <ThreadMenu threadInfo={threadInfo} />; threadMenu = <ThreadMenu threadInfo={threadInfo} />;
} }
const bannerText =
!!threadInfo.pinnedCount && pinnedMessageCountText(threadInfo.pinnedCount);
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const pushThreadPinsModal = React.useCallback(() => {
pushModal(
<InputStateContext.Provider value={inputState}>
<PinnedMessagesModal threadInfo={threadInfo} />
</InputStateContext.Provider>,
);
}, [pushModal, inputState, threadInfo]);
const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) {
return null;
}
return (
<div className={css.pinnedCountBanner}>
<a className={css.pinnedCountText} onClick={pushThreadPinsModal}>
{bannerText}
<ChevronRight size={14} className={css.chevronRight} />
</a>
</div>
);
}, [bannerText, pushThreadPinsModal]);
const onClickSearch = React.useCallback( const onClickSearch = React.useCallback(
() => () =>
pushModal( pushModal(
<InputStateContext.Provider value={inputState}> <InputStateContext.Provider value={inputState}>
<MessageSearchModal threadInfo={threadInfo} /> <MessageSearchModal threadInfo={threadInfo} />
</InputStateContext.Provider>, </InputStateContext.Provider>,
), ),
Show All 15 Lines <>
size={24} size={24}
icon="search" icon="search"
className={css.searchButtonIcon} className={css.searchButtonIcon}
/> />
</Button> </Button>
{threadMenu} {threadMenu}
</div> </div>
</div> </div>
{pinnedCountBanner} <PinnedMessagesBanner threadInfo={threadInfo} />
</> </>
); );
} }
export default ThreadTopBar; export default ThreadTopBar;
View Options

keyserver/addons/rust-node-addon/src/identity_client/upload_one_time_keys.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { ChevronRight } from 'react-feather';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { threadIsPending } from 'lib/shared/thread-utils.js'; import { threadIsPending } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import { pinnedMessageCountText } from 'lib/utils/message-pinning-utils.js';
import PinnedMessagesBanner from './pinned-messages-banner.react.js';
import ThreadMenu from './thread-menu.react.js'; import ThreadMenu from './thread-menu.react.js';
import css from './thread-top-bar.css'; import css from './thread-top-bar.css';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
import Button from '../components/button.react.js'; import Button from '../components/button.react.js';
import { InputStateContext } from '../input/input-state.js'; import { InputStateContext } from '../input/input-state.js';
import PinnedMessagesModal from '../modals/chat/pinned-messages-modal.react.js';
import MessageSearchModal from '../modals/search/message-search-modal.react.js'; import MessageSearchModal from '../modals/search/message-search-modal.react.js';
type ThreadTopBarProps = { type ThreadTopBarProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadTopBar(props: ThreadTopBarProps): React.Node { function ThreadTopBar(props: ThreadTopBarProps): React.Node {
const { threadInfo } = props; const { threadInfo } = props;
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
let threadMenu = null; let threadMenu = null;
if (!threadIsPending(threadInfo.id)) { if (!threadIsPending(threadInfo.id)) {
threadMenu = <ThreadMenu threadInfo={threadInfo} />; threadMenu = <ThreadMenu threadInfo={threadInfo} />;
} }
const bannerText =
!!threadInfo.pinnedCount && pinnedMessageCountText(threadInfo.pinnedCount);
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const pushThreadPinsModal = React.useCallback(() => {
pushModal(
<InputStateContext.Provider value={inputState}>
<PinnedMessagesModal threadInfo={threadInfo} />
</InputStateContext.Provider>,
);
}, [pushModal, inputState, threadInfo]);
const pinnedCountBanner = React.useMemo(() => {
if (!bannerText) {
return null;
}
return (
<div className={css.pinnedCountBanner}>
<a className={css.pinnedCountText} onClick={pushThreadPinsModal}>
{bannerText}
<ChevronRight size={14} className={css.chevronRight} />
</a>
</div>
);
}, [bannerText, pushThreadPinsModal]);
const onClickSearch = React.useCallback( const onClickSearch = React.useCallback(
() => () =>
pushModal( pushModal(
<InputStateContext.Provider value={inputState}> <InputStateContext.Provider value={inputState}>
<MessageSearchModal threadInfo={threadInfo} /> <MessageSearchModal threadInfo={threadInfo} />
</InputStateContext.Provider>, </InputStateContext.Provider>,
), ),
Show All 15 Lines <>
size={24} size={24}
icon="search" icon="search"
className={css.searchButtonIcon} className={css.searchButtonIcon}
/> />
</Button> </Button>
{threadMenu} {threadMenu}
</div> </div>
</div> </div>
{pinnedCountBanner} <PinnedMessagesBanner threadInfo={threadInfo} />
</> </>
); );
} }
export default ThreadTopBar; export default ThreadTopBar;