web] make user profile accessible from a user entity in a robotext
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:21 AM.

Details

Reviewers

atul
inka

Commits

rCOMM631e3b5eb906: [lib/native/web] make user profile accessible from a user entity in a robotext

Summary

This diff introduces a UserEntity component to be used by the InnerRobotextMesssage. UserEntity will be a touchable that wil navigate to the user profile when onPress is triggered

Depends on D9388

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 6 2023, 4:21 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:21 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 4:25 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9388: [native] make user profile accessible from ThreadSettingsMember.

ginsu attached a referenced file: F794317: Screen Recording 2023-10-06 at 7.24.44 AM.mov. (Show Details)

ginsu added inline comments.

web/chat/robotext-message.react.js
141–149 ↗	(On Diff #31736)	Since `entityTextToReact` lives in `lib` I created this dummy `UserEntity` component for web that will be used temporarily to appease flow

ginsu added a child revision: D9390: [native] make user profile accessible from MessageReactionsModal.Oct 6 2023, 4:32 AM

Harbormaster completed remote builds in B23047: Diff 31736.Oct 6 2023, 4:38 AM

ginsu requested review of this revision.Oct 6 2023, 4:38 AM

atul accepted this revision.Oct 9 2023, 12:51 PM

atul added inline comments.

web/chat/robotext-message.react.js
141–149 ↗	(On Diff #31736)	Can you include a comment explaining that and linking to this comment in this diff

This revision is now accepted and ready to land.Oct 9 2023, 12:51 PM

address comments

Harbormaster completed remote builds in B23127: Diff 31834.Oct 9 2023, 2:22 PM

rebase before landing

Harbormaster completed remote builds in B23163: Diff 31894.Oct 11 2023, 1:58 AM

Closed by commit rCOMM631e3b5eb906: [lib/native/web] make user profile accessible from a user entity in a robotext (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM631e3b5eb906: [lib/native/web] make user profile accessible from a user entity in a robotext.

ashoat added inline comments.Oct 15 2023, 3:41 PM

lib/utils/entity-text.js
368 ↗	(On Diff #31908)	`usernameText` isn't read-only here
native/chat/inner-robotext-message.react.js
123–124 ↗	(On Diff #31908)	Shouldn't these be read-only?
web/chat/robotext-message.react.js
142–143 ↗	(On Diff #31908)	Shouldn't these be read-only?