Page MenuHomePhabricator
Differential D9392

[lib/native] introduce parseUserMentions function
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 9:32 PM
Unknown Object (File)
Thu, Mar 13, 4:52 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:45 PM
Unknown Object (File)
Sun, Mar 2, 4:51 AM
Unknown Object (File)
Feb 21 2025, 5:41 AM
View All 88 Files
Subscribers
ashoat
rohan
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM59b2c16215c1: [lib/native] introduce parseUserMentions function
Summary

This diff introduces parseUserMentions. parseUserMentions takes the username found in the markdown entity/capture and uses that username to find the id of that user using memberMap

This is step 2 in the list below
Outlined below are the steps I will take to make @metion of a user into a touchable

  1. Introduce createMemberMapForUserMentions function (Right now we only store a set of usernames but we also will want to know the id of the user based on the username)
  2. Introduce parseUserMentions function (We will use this function to get and return a userID from the membersMap)
  3. Introduce userProfileBottomSheetActive state to the markdown context (This will be used for disabling the press to focus on a message functionality)
  4. Introduce MarkdownUserMention component (this will render the touchable that will navigate to the user profile)

Depends on D9391

Test Plan

Logged out the userID and confirmed that I was getting the correct value

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 6 2023, 4:57 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:57 AM
ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 5:02 AM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9391: [lib/native/web] introduce createMemberMapForUserMentions function.
Harbormaster completed remote builds in B23050: Diff 31739.Oct 6 2023, 5:15 AM
ginsu requested review of this revision.Oct 6 2023, 5:15 AM
ginsu added a child revision: D9393: [native] introduce userProfileBottomSheetActive state to markdown context.Oct 6 2023, 5:16 AM
atul accepted this revision.Oct 9 2023, 1:30 PM
atul added a reviewer: rohan.
atul added a subscriber: rohan.

Looks good, haven't worked with these markdown rules before so adding @rohan to take another look

rohan accepted this revision.Oct 10 2023, 6:43 AM

Seems reasonable, could be good to test it with an ENS name being mentioned as well to cover all grounds

This revision is now accepted and ready to land.Oct 10 2023, 6:43 AM
ginsu added a comment.Oct 11 2023, 1:55 AM

Seems reasonable, could be good to test it with an ENS name being mentioned as well to cover all grounds

Good shout, as I was reconfirming I realized I forgot .toLowerCase() for the memberUsername, and this was triggering the invariant for ENS names.

ginsu updated this revision to Diff 31897.Oct 11 2023, 1:56 AM

address comments + rebase before landing

This revision was landed with ongoing or failed builds.Oct 11 2023, 2:39 AM
Closed by commit rCOMM59b2c16215c1: [lib/native] introduce parseUserMentions function (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM59b2c16215c1: [lib/native] introduce parseUserMentions function.

Revision Contents
Changeset List

PathSize
lib/
shared/
21 lines
native/
markdown/
5 lines

Diff 31897

View Options

lib/shared/markdown.js

#!/bin/bash #!/bin/bash
set -e set -e
pushd transferred/server/cmake/build pushd /transferred/server/cmake/build
make test ARGS="-V" make test ARGS="-V"
popd # transferred/server/cmake/build popd # /transferred/server/cmake/build
View Options

native/markdown/rules.react.js

#!/bin/bash #!/bin/bash
set -e set -e
pushd transferred/server/cmake/build pushd /transferred/server/cmake/build
make test ARGS="-V" make test ARGS="-V"
popd # transferred/server/cmake/build popd # /transferred/server/cmake/build