Paths

Table of Contentst

[identity] Add function to retrieve user's devices
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:13 AM.

Details

Reviewers

michal
varun

Commits

rCOMM5bb485784ac3: [identity] Add function to retrieve user's devices

Summary

This function retrieves all Device rows for given user. This is a counterpart of get_keys_for_user function in "legacy" schema.

Depends on D10216

Test Plan

Added a few test rows (with both device- and devicelist- prefixes) to the identity-devices table and verified that the function returns only the device- items.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 7 2023, 12:13 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:13 AM

bartek added a child revision: D10218: [identity] Add function to check if device exists.Dec 7 2023, 12:17 AM

bartek published this revision for review.Dec 7 2023, 1:06 AM

Harbormaster failed remote builds in B24845: Diff 34367!Dec 7 2023, 1:29 AM

varun accepted this revision.Dec 8 2023, 12:39 AM

varun added inline comments.

services/identity/src/database/device_list.rs
309	maybe i missed it but is there a reason why this isn't a client method? i.e. should this be in an `impl DatabaseClient` block instead?

This revision is now accepted and ready to land.Dec 8 2023, 12:39 AM

bartek added inline comments.Dec 8 2023, 1:01 AM

services/identity/src/database/device_list.rs
309	https://phab.comm.dev/D10216#inline-62750

Move function into impl DatabaseClient

Harbormaster completed remote builds in B24964: Diff 34502.Dec 12 2023, 12:30 AM

Closed by commit rCOMM5bb485784ac3: [identity] Add function to retrieve user's devices (authored by bartek). · Explain WhyJan 5 2024, 1:22 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5bb485784ac3: [identity] Add function to retrieve user's devices.

bartek mentioned this in D10216: identity] Add function to get current device list timestamp.Jan 5 2024, 6:06 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

52 lines

Diff 34367

View Options

services/identity/src/database/device_list.rs

[identity] Add function to retrieve user's devicesClosedPublicActions