[identity] Augment get_keyserver_keys to use devices table
ClosedPublic
Actions

Authored by bartek on Dec 12 2023, 1:05 AM.

Details

Reviewers

varun
michal

Commits

rCOMMf1100326aa96: [identity] Augment get_keyserver_keys to use devices table

Summary

Similiar to D10303 - updated the function to try getting keyserver keys from devices table first, then fall back to the users table.

This code can be greatly simplified once we remove "legacy" devices attribute from users table.

Depends on D10303

Test Plan

Repeated steps from D10303, just made sure the device is of type keyserver. Also added one more non-keyserver device to make sure filtering is working.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 12 2023, 1:05 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 12 2023, 1:05 AM

Harbormaster completed remote builds in B24975: Diff 34513.Dec 12 2023, 2:10 AM

bartek published this revision for review.Dec 12 2023, 3:21 AM

bartek added a child revision: D10397: [identity] Add function to remove device from list.Dec 19 2023, 4:49 AM

varun accepted this revision.Dec 29 2023, 5:54 AM

This revision is now accepted and ready to land.Dec 29 2023, 5:54 AM

Closed by commit rCOMMf1100326aa96: [identity] Augment get_keyserver_keys to use devices table (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf1100326aa96: [identity] Augment get_keyserver_keys to use devices table.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

52 lines

Diff 34513

View Options

services/identity/src/database.rs

This file contains generated code, which does not normally need to be reviewed. Show File Contents

[identity] Augment get_keyserver_keys to use devices tableClosedPublicActions