[identity] Create function to determine primary device
ClosedPublic
Actions

Authored by bartek on Dec 19 2023, 4:57 AM.

Details

Reviewers

michal
varun

Commits

rCOMMf743c9d8f7ed: [identity] Create function to determine primary device

Summary

Resolves ENG-5287. Implements a function that determines which device should be primary basing on user's current devices.

Depends on D10399

Test Plan

Unit tests covering all cases from the ENG-5844 testing task.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 19 2023, 4:57 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 19 2023, 4:57 AM

Remove accidentaly committed comments

Harbormaster completed remote builds in B25213: Diff 34831.Dec 19 2023, 5:59 AM

bartek added a child revision: D10404: [identity] Reorder device list when updated.Dec 19 2023, 6:22 AM

bartek published this revision for review.Dec 19 2023, 6:32 AM

Harbormaster completed remote builds in B25214: Diff 34832.Dec 19 2023, 6:32 AM

varun requested changes to this revision.Jan 10 2024, 3:31 PM

varun added inline comments.

services/identity/src/database/device_list.rs
1041	not sure i understand the part in parentheses here
1141	together
1162	can we add a test that shows that if there are two mobile devices with the same code version and latest login time, we still deterministically select the primary device?

This revision now requires changes to proceed.Jan 10 2024, 3:31 PM

Add test to check if selection is deterministic

bartek added inline comments.Jan 11 2024, 9:18 AM

services/identity/src/database/device_list.rs
1041	Yeah it doesn't make sense

varun accepted this revision.Jan 11 2024, 9:22 AM

This revision is now accepted and ready to land.Jan 11 2024, 9:22 AM

Harbormaster completed remote builds in B25704: Diff 35545.Jan 11 2024, 9:30 AM

Closed by commit rCOMMf743c9d8f7ed: [identity] Create function to determine primary device (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf743c9d8f7ed: [identity] Create function to determine primary device.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

163 lines

Diff 34832

View Options

services/identity/src/database/device_list.rs

// @flow		// @flow

import * as React from 'react';		import * as React from 'react';

import {		import {
leaveThreadActionTypes,		leaveThreadActionTypes,
useLeaveThread,		useLeaveThread,
} from 'lib/actions/thread-actions.js';		} from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js';		import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/swmansion-icon.react.js';		import SWMansionIcon from 'lib/components/swmansion-icon.react.js';
import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js';		import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js';
import { childThreadInfos } from 'lib/selectors/thread-selectors.js';		import { childThreadInfos } from 'lib/selectors/thread-selectors.js';
import {		import {
threadHasPermission,
threadIsChannel,		threadIsChannel,
		useThreadHasPermission,
viewerIsMember,		viewerIsMember,
} from 'lib/shared/thread-utils.js';		} from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypes } from 'lib/types/thread-types-enum.js';		import { threadTypes } from 'lib/types/thread-types-enum.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';		import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';

import css from './thread-menu.css';		import css from './thread-menu.css';
▲ Show 20 Lines • Show All 106 Lines • ▼ Show 20 Lines	return (
key="sidebars"		key="sidebars"
text="Threads"		text="Threads"
icon="arrow-right"		icon="arrow-right"
onClick={onClickSidebars}		onClick={onClickSidebars}
/>		/>
);		);
}, [hasSidebars, onClickSidebars]);		}, [hasSidebars, onClickSidebars]);

const canCreateSubchannels = React.useMemo(		const canCreateSubchannels = useThreadHasPermission(
() => threadHasPermission(threadInfo, threadPermissions.CREATE_SUBCHANNELS),		threadInfo,
[threadInfo],		threadPermissions.CREATE_SUBCHANNELS,
);		);

const hasSubchannels = React.useMemo(() => {		const hasSubchannels = React.useMemo(() => {
return !!childThreads?.some(threadIsChannel);		return !!childThreads?.some(threadIsChannel);
}, [childThreads]);		}, [childThreads]);

const onClickViewSubchannels = React.useCallback(		const onClickViewSubchannels = React.useCallback(
() =>		() =>
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Lines	() =>
threadInfo={threadInfo}		threadInfo={threadInfo}
onClose={popModal}		onClose={popModal}
onConfirm={onConfirmLeaveThread}		onConfirm={onConfirmLeaveThread}
/>,		/>,
),		),
[popModal, onConfirmLeaveThread, pushModal, threadInfo],		[popModal, onConfirmLeaveThread, pushModal, threadInfo],
);		);

const leaveThreadItem = React.useMemo(() => {		const canLeaveThread = useThreadHasPermission(
const canLeaveThread = threadHasPermission(
threadInfo,		threadInfo,
threadPermissions.LEAVE_THREAD,		threadPermissions.LEAVE_THREAD,
);		);
		const leaveThreadItem = React.useMemo(() => {
if (!viewerIsMember(threadInfo) \|\| !canLeaveThread) {		if (!viewerIsMember(threadInfo) \|\| !canLeaveThread) {
return null;		return null;
}		}
return (		return (
<MenuItem		<MenuItem
key="leave"		key="leave"
text="Leave chat"		text="Leave chat"
icon="logout"		icon="logout"
dangerous		dangerous
onClick={onClickLeaveThread}		onClick={onClickLeaveThread}
/>		/>
);		);
}, [onClickLeaveThread, threadInfo]);		}, [onClickLeaveThread, threadInfo, canLeaveThread]);

const onClickPromoteSidebarToThread = React.useCallback(		const onClickPromoteSidebarToThread = React.useCallback(
() =>		() =>
pushModal(		pushModal(
<SidebarPromoteModal		<SidebarPromoteModal
threadInfo={threadInfo}		threadInfo={threadInfo}
onClose={popModal}		onClose={popModal}
onConfirm={onPromoteSidebar}		onConfirm={onPromoteSidebar}
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines

[identity] Create function to determine primary deviceClosedPublicActions