Paths

Table of Contentst

[identity] Add function to delete all user devices data
ClosedPublic
Actions

Authored by bartek on Dec 8 2023, 12:40 PM.

Details

Reviewers

varun
michal

Commits

rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data

Summary

Resolves ENG-5120.

Depends on D10221

Test Plan

Called DeleteUser RPC and verified with awslocal dynamodb scan that no rows were left in the identity-devices table with given userID.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 8 2023, 12:40 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 12:40 PM

bartek added a child revision: D10247: [identity] Add function to get device list history.Dec 8 2023, 12:45 PM

Harbormaster failed remote builds in B24883: Diff 34412!Dec 8 2023, 12:54 PM

Harbormaster completed remote builds in B24883: Diff 34412.Dec 8 2023, 1:11 PM

bartek published this revision for review.Dec 8 2023, 1:12 PM

bartek added inline comments.

services/identity/src/database/device_list.rs
455–457 ↗	(On Diff #34412)	leftover

Move function into impl DatabaseClient

Harbormaster completed remote builds in B24969: Diff 34507.Dec 12 2023, 9:06 AM

varun accepted this revision.Dec 14 2023, 2:10 AM

varun added inline comments.

services/identity/src/database.rs
725 ↗	(On Diff #34507)	should we use the same format as on line 722?

This revision is now accepted and ready to land.Dec 14 2023, 2:10 AM

Fix debug format

bartek edited parent revisions, added: D10220: [identity] Add function to add new device to the list; removed: D10221: [identity] Add devices to the new list after login and register.Jan 5 2024, 8:54 AM

Harbormaster completed remote builds in B25529: Diff 35265.Jan 5 2024, 9:05 AM

Closed by commit rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data. · Explain WhyJan 5 2024, 9:22 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

4 lines

database/

device_list.rs

60 lines

Diff 35265

View Options

services/identity/src/database.rs