Page MenuHomePhabricator
Differential D10246

[identity] Add function to delete all user devices data
ClosedPublic
Actions

Authored by bartek on Dec 8 2023, 4:40 AM.
Tags
None
Referenced Files
F2193067: D10246.id35275.diff
Thu, Jul 4, 9:02 PM
F2192874: D10246.id34412.diff
Thu, Jul 4, 8:38 PM
F2192803: D10246.id35265.diff
Thu, Jul 4, 8:31 PM
F2192493: D10246.id34507.diff
Thu, Jul 4, 7:55 PM
Unknown Object (File)
Wed, Jul 3, 12:44 PM
Unknown Object (File)
Tue, Jul 2, 4:39 PM
Unknown Object (File)
Sun, Jun 30, 1:59 PM
Unknown Object (File)
Fri, Jun 28, 12:44 AM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data
Summary

Resolves ENG-5120.

Depends on D10221

Test Plan

Called DeleteUser RPC and verified with awslocal dynamodb scan that no rows were left in the identity-devices table with given userID.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 8 2023, 4:40 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 4:40 AM
bartek added a child revision: D10247: [identity] Add function to get device list history.Dec 8 2023, 4:45 AM
Harbormaster failed remote builds in B24883: Diff 34412!Dec 8 2023, 4:54 AM
Harbormaster completed remote builds in B24883: Diff 34412.Dec 8 2023, 5:11 AM
bartek published this revision for review.Dec 8 2023, 5:12 AM
bartek added inline comments.
services/identity/src/database/device_list.rs
455–457 ↗(On Diff #34412)

leftover

bartek updated this revision to Diff 34507.EditedDec 11 2023, 11:29 PM

Move function into impl DatabaseClient

Harbormaster completed remote builds in B24969: Diff 34507.Dec 12 2023, 1:06 AM
varun accepted this revision.Dec 13 2023, 6:10 PM
varun added inline comments.
services/identity/src/database.rs
725 ↗(On Diff #34507)

should we use the same format as on line 722?

This revision is now accepted and ready to land.Dec 13 2023, 6:10 PM
bartek updated this revision to Diff 35265.Jan 5 2024, 12:46 AM

Fix debug format

bartek edited parent revisions, added: D10220: [identity] Add function to add new device to the list; removed: D10221: [identity] Add devices to the new list after login and register.Jan 5 2024, 12:54 AM
Harbormaster completed remote builds in B25529: Diff 35265.Jan 5 2024, 1:05 AM
Closed by commit rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data (authored by bartek). · Explain WhyJan 5 2024, 1:22 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMf2ed271ea09c: [identity] Add function to delete all user devices data.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
4 lines
database/
60 lines

Diff 35275

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...