[lib] Remove `isDefault` field from `RoleInfo`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 9:28 PM.

Details

Reviewers

ginsu
tomek
michal
kamil

Commits

rCOMM0f3def7e94b8: [lib] Remove `isDefault` field from `RoleInfo`

Summary

We previously removed all usages of RoleInfo.isDefault on the native/web client, so we can safely remove it from RoleInfo.

As usual, there will be a native/web migration to go along with this change. Will actually update the existing specialRole migration in place since it makes sense to couple the inclusion of specialRole and exclusion of isDefault in a single pass.

Depends on D11252

Test Plan

flow + verified that RoleInfos sent from the keyserver have the isDefault field excluded.

Did a search through the codebase to ensure there were not any instances of isDefault that are relevant to changing this client type.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:28 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:28 PM

atul added a child revision: D11254: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`.Mar 5 2024, 9:42 PM

Harbormaster completed remote builds in B27350: Diff 37872.Mar 5 2024, 9:52 PM

atul requested review of this revision.Mar 5 2024, 9:52 PM

Do we have a task for the migration?

This revision is now accepted and ready to land.Mar 6 2024, 4:23 AM

In D11253#325063, @tomek wrote:

Do we have a task for the migration?

Migration will be handled by D11188 and D11099

rebase before landing

Harbormaster completed remote builds in B27608: Diff 38204.Mar 19 2024, 12:32 PM

Closed by commit rCOMM0f3def7e94b8: [lib] Remove `isDefault` field from `RoleInfo` (authored by atul). · Explain WhyMar 19 2024, 6:54 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0f3def7e94b8: [lib] Remove `isDefault` field from `RoleInfo`.

This diff appears to have changed the behavior of rawThreadInfoFromServerThreadInfo even when !shouldIncludeSpecialRoleFieldInRoles... all clients that support minimally-encoded RawThreadInfos (basically all modern clients) are now getting the new format of RoleInfo, which they definitely don't support