Page MenuHomePhabricator

[CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`
ClosedPublic

Authored by atul on Mar 6 2024, 2:28 PM.
Tags
None
Referenced Files
F3357464: D11262.id37935.diff
Sat, Nov 23, 11:46 PM
F3357237: D11262.id37934.diff
Sat, Nov 23, 10:58 PM
F3357186: D11262.id37902.diff
Sat, Nov 23, 10:44 PM
F3356873: D11262.diff
Sat, Nov 23, 9:08 PM
Unknown Object (File)
Thu, Nov 21, 1:20 AM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Subscribers
None

Details

Summary

To resolve build issue after updating Xcode from 15.2 to 15.3.

Specifically, looks like there a number of changes to C++ Standard Library: https://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes#C++-Standard-Library

The relevant piece might be:

The <experimental/algorithm> and <experimental/functional> headers have been removed, since all the contents have been implemented in namespace std.

We weren't previously including <experimental/functional>, but now it requires us to include <functional> in order for it to recognize std::function.

We include <functional> elsewhere in the codebase, so maybe it was getting resolved by coincidence or something in the past? Either way, this change fixes the iOS build.


Depends on D11261

Test Plan

Before: didn't build
After: does build

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul retitled this revision from [CommCoreModule] Add `#include <string>` to `NotificationsCryptoModule` to [CommCoreModule] Add `#include <functional>` to `NotificationsCryptoModule`.Mar 6 2024, 2:30 PM
ginsu published this revision for review.Mar 6 2024, 2:36 PM

rubber stamping, one thing to note is that it looks like this diff is part of an unrelated stack

This revision is now accepted and ready to land.Mar 6 2024, 2:36 PM

This is a sign that all developers on the team should update their XCode version shortly.

This revision was landed with ongoing or failed builds.Mar 7 2024, 8:37 AM
This revision was automatically updated to reflect the committed changes.