[lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 2:22 PM.

Details

Reviewers

tomek
ginsu
michal
kamil
ashoat

Commits

rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and…

Summary

Noticed as part of D11205 that these hooks had threadInfo in their dep list which wasn't necessary.

Depends on D11209

Test Plan

ESLint/Flow

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11248 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 2:22 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 2:22 PM

Harbormaster completed remote builds in B27344: Diff 37865.Mar 5 2024, 2:37 PM

atul requested review of this revision.Mar 5 2024, 2:37 PM

ashoat accepted this revision.Mar 5 2024, 6:01 PM

This revision is now accepted and ready to land.Mar 5 2024, 6:01 PM

atul added a child revision: D11252: [lib] Make `specialRoles` field of `RoleInfo` required.Mar 5 2024, 9:20 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 19 2024, 10:28 AM

Closed by commit rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and….

Harbormaster completed remote builds in B27603: Diff 38196.Mar 19 2024, 10:41 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

4 lines

Diff 38196

View Options

lib/shared/thread-utils.js

[lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`ClosedPublicActions