Page MenuHomePhabricator

[lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`
ClosedPublic

Authored by atul on Mar 6 2024, 2:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:31 AM
Unknown Object (File)
Fri, Nov 22, 4:47 AM
Unknown Object (File)
Fri, Nov 22, 1:49 AM
Unknown Object (File)
Thu, Nov 21, 6:23 AM
Unknown Object (File)
Thu, Nov 21, 3:21 AM
Unknown Object (File)
Wed, Nov 20, 2:16 PM
Unknown Object (File)
Fri, Nov 8, 5:27 PM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Subscribers

Details

Summary

We're updating the specialRole client migrations to include exclusion of isDefault field. This is corresponding keyserver change to match that.


Depends on D11254

Test Plan

Set the includeSpecialRoleFieldInRoles flag manually and observe that isDefault included before and excluded after.

Will attach screenshots.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11261 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Mar 6 2024, 2:26 PM
tomek added inline comments.
lib/shared/thread-utils.js
904–907 ↗(On Diff #37901)

Not sure if it is worth using an util for it - in most of the places we're simply spreading the value

This revision is now accepted and ready to land.Mar 7 2024, 1:18 AM
lib/shared/thread-utils.js
904–907 ↗(On Diff #37901)

Considered destructuring to exclude isDefault but thought it got a little difficult to read with (([key, {isDefault, ...role}]) => .... Also felt that _omit made it more explicit.

This revision was landed with ongoing or failed builds.Mar 20 2024, 11:13 AM
This revision was automatically updated to reflect the committed changes.