This diff improves the error handling for creating a farcaster tag blob. If there is an error we will display a message to the user for why the request failed
Depends on D11793
Details
Details
Please see the demo video below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Copy looks okay. Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time
| native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js | ||
|---|---|---|
| 94 ↗ | (On Diff #39586) | Can we move this to onOptionSelected? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked |
Comment Actions
Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time
Agree this would be nice to have, but also agree that this should be considered out of scope for now. I created a linear task to track this piece of feedback:
https://linear.app/comm/issue/ENG-8032/filter-list-of-taken-farcaster-channels