Page MenuHomePhabricator

[native] Consume `useThreadInChatList` in `native/ThreadSettings`
ClosedPublic

Authored by atul on May 6 2024, 2:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 6:59 PM
Unknown Object (File)
Sun, Dec 22, 8:28 PM
Unknown Object (File)
Sun, Dec 22, 8:28 PM
Unknown Object (File)
Sun, Dec 22, 8:28 PM
Unknown Object (File)
Sun, Dec 22, 8:27 PM
Unknown Object (File)
Sun, Dec 22, 8:27 PM
Unknown Object (File)
Nov 29 2024, 2:00 PM
Unknown Object (File)
Nov 29 2024, 1:13 PM
Subscribers
None

Details

Summary

Similar to rest of stack, we want to replace usages of threadHasPermission with useThreadHasPermission which we're doing indirectly when we replace threadInChatList with useThreadInChatList.


Depends on D11915

Test Plan

flow + close reading for now

Logged value of isThreadInChatList and ensured it was same before/after change.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.May 6 2024, 2:16 PM

flow + close reading for now

Sounds risky for a change that changes the flow.

native/chat/settings/thread-settings.react.js
1166

I find these names a bit confusing - they don't indicate that they are boolean flags. This might be expensive, but I think it would be better to put is somewhere inside them.

This revision is now accepted and ready to land.May 7 2024, 1:53 AM

address feedback (useThreadInChatList -> useIsThreadInChatList)

This revision was landed with ongoing or failed builds.May 14 2024, 1:26 PM
This revision was automatically updated to reflect the committed changes.