[native] Consume `useThreadInChatList` in `native/ThreadSettings`
ClosedPublic
Actions

Authored by atul on May 6 2024, 9:11 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun
will

Commits

rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings`

Summary

Similar to rest of stack, we want to replace usages of threadHasPermission with useThreadHasPermission which we're doing indirectly when we replace threadInChatList with useThreadInChatList.

Depends on D11915

Test Plan

flow + close reading for now

Logged value of isThreadInChatList and ensured it was same before/after change.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11916 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 6 2024, 9:11 PM

atul published this revision for review.May 6 2024, 9:16 PM

Harbormaster completed remote builds in B28720: Diff 39874.May 6 2024, 9:29 PM

flow + close reading for now

Sounds risky for a change that changes the flow.

native/chat/settings/thread-settings.react.js
1166 ↗	(On Diff #39874)	I find these names a bit confusing - they don't indicate that they are boolean flags. This might be expensive, but I think it would be better to put `is` somewhere inside them.