Page MenuHomePhabricator
Differential D12138

Implement SQLite API to handle entry store
ClosedPublic
Actions

Authored by marcin on May 21 2024, 3:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 9:50 AM
Unknown Object (File)
Tue, Apr 8, 9:21 AM
Unknown Object (File)
Tue, Apr 8, 7:30 AM
Unknown Object (File)
Mon, Apr 7, 2:02 AM
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Sun, Apr 6, 5:55 AM
Unknown Object (File)
Sun, Mar 23, 8:56 AM
Unknown Object (File)
Thu, Mar 20, 8:32 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM34fae12d44fa: Implement SQLite API to handle entry store
Summary

This differential implements SQLiteQueryExecutor API necessary to persist entry store.

Test Plan

Compile

Diff Detail

Repository
rCOMM Comm
Branch
marcin-tomek/eng-3486
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 21 2024, 3:24 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 3:24 AM
marcin added a parent revision: D12137: [lib] Create entry store operations.May 21 2024, 3:25 AM
marcin added inline comments.
web/shared-worker/queries/entry-queries.test.js
38–55

This will be removed soon as @tomek is implementing it in his files.

Harbormaster completed remote builds in B29086: Diff 40449.May 21 2024, 3:40 AM
marcin requested review of this revision.May 21 2024, 3:40 AM
marcin added a child revision: D12142: Implement JSI for EntryStore.May 21 2024, 6:15 AM
tomek accepted this revision.May 21 2024, 6:17 AM
This revision is now accepted and ready to land.May 21 2024, 6:17 AM
marcin updated this revision to Diff 40463.May 21 2024, 6:55 AM

entry_info -> entry

Harbormaster completed remote builds in B29099: Diff 40463.May 21 2024, 7:18 AM
marcin updated this revision to Diff 40473.May 21 2024, 7:46 AM

Rebase

tomek edited parent revisions, added: D12141: [lib] Create entry store handler; removed: D12137: [lib] Create entry store operations.May 21 2024, 7:53 AM
Harbormaster completed remote builds in B29107: Diff 40473.May 21 2024, 8:08 AM
marcin edited the test plan for this revision. (Show Details)May 22 2024, 8:44 AM
Closed by commit rCOMM34fae12d44fa: Implement SQLite API to handle entry store (authored by marcin). · Explain WhyMay 27 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM34fae12d44fa: Implement SQLite API to handle entry store.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
5 lines
4 lines
55 lines
entities/
23 lines
web/
cpp/
7 lines
shared-worker/
_generated/
queries/
130 lines
types/
6 lines

Diff 40449

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesexport default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(
state: T, state: T,
action: BaseAction, action: BaseAction,
onStateDifference: (message: string) => mixed, onStateDifference: (message: string) => mixed,
): { state: T, storeOperations: StoreOperations } { ): { state: T, storeOperations: StoreOperations } {
const { threadStore, newThreadInconsistencies, threadStoreOperations } = const { threadStore, newThreadInconsistencies, threadStoreOperations } =
reduceThreadInfos(state.threadStore, action); reduceThreadInfos(state.threadStore, action);
const { threadInfos } = threadStore; const { threadInfos } = threadStore;
const [entryStore, newEntryInconsistencies] = reduceEntryInfos( const { entryStore, reportCreationRequests: newEntryInconsistencies } =
state.entryStore, reduceEntryInfos(state.entryStore, action, threadInfos);
action,
threadInfos,
);
const onStateDifferenceForStaff = (message: string) => { const onStateDifferenceForStaff = (message: string) => {
const isCurrentUserStaff = state.currentUserInfo?.id const isCurrentUserStaff = state.currentUserInfo?.id
? isStaff(state.currentUserInfo.id) ? isStaff(state.currentUserInfo.id)
: false; : false;
if (isCurrentUserStaff || isDev) { if (isCurrentUserStaff || isDev) {
onStateDifference(message); onStateDifference(message);
} }
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesexport default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(
state: T, state: T,
action: BaseAction, action: BaseAction,
onStateDifference: (message: string) => mixed, onStateDifference: (message: string) => mixed,
): { state: T, storeOperations: StoreOperations } { ): { state: T, storeOperations: StoreOperations } {
const { threadStore, newThreadInconsistencies, threadStoreOperations } = const { threadStore, newThreadInconsistencies, threadStoreOperations } =
reduceThreadInfos(state.threadStore, action); reduceThreadInfos(state.threadStore, action);
const { threadInfos } = threadStore; const { threadInfos } = threadStore;
const [entryStore, newEntryInconsistencies] = reduceEntryInfos( const { entryStore, reportCreationRequests: newEntryInconsistencies } =
state.entryStore, reduceEntryInfos(state.entryStore, action, threadInfos);
action,
threadInfos,
);
const onStateDifferenceForStaff = (message: string) => { const onStateDifferenceForStaff = (message: string) => {
const isCurrentUserStaff = state.currentUserInfo?.id const isCurrentUserStaff = state.currentUserInfo?.id
? isStaff(state.currentUserInfo.id) ? isStaff(state.currentUserInfo.id)
: false; : false;
if (isCurrentUserStaff || isDev) { if (isCurrentUserStaff || isDev) {
onStateDifference(message); onStateDifference(message);
} }
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesexport default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(
state: T, state: T,
action: BaseAction, action: BaseAction,
onStateDifference: (message: string) => mixed, onStateDifference: (message: string) => mixed,
): { state: T, storeOperations: StoreOperations } { ): { state: T, storeOperations: StoreOperations } {
const { threadStore, newThreadInconsistencies, threadStoreOperations } = const { threadStore, newThreadInconsistencies, threadStoreOperations } =
reduceThreadInfos(state.threadStore, action); reduceThreadInfos(state.threadStore, action);
const { threadInfos } = threadStore; const { threadInfos } = threadStore;
const [entryStore, newEntryInconsistencies] = reduceEntryInfos( const { entryStore, reportCreationRequests: newEntryInconsistencies } =
state.entryStore, reduceEntryInfos(state.entryStore, action, threadInfos);
action,
threadInfos,
);
const onStateDifferenceForStaff = (message: string) => { const onStateDifferenceForStaff = (message: string) => {
const isCurrentUserStaff = state.currentUserInfo?.id const isCurrentUserStaff = state.currentUserInfo?.id
? isStaff(state.currentUserInfo.id) ? isStaff(state.currentUserInfo.id)
: false; : false;
if (isCurrentUserStaff || isDev) { if (isCurrentUserStaff || isDev) {
onStateDifference(message); onStateDifference(message);
} }
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntryInfo.h

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesexport default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(
state: T, state: T,
action: BaseAction, action: BaseAction,
onStateDifference: (message: string) => mixed, onStateDifference: (message: string) => mixed,
): { state: T, storeOperations: StoreOperations } { ): { state: T, storeOperations: StoreOperations } {
const { threadStore, newThreadInconsistencies, threadStoreOperations } = const { threadStore, newThreadInconsistencies, threadStoreOperations } =
reduceThreadInfos(state.threadStore, action); reduceThreadInfos(state.threadStore, action);
const { threadInfos } = threadStore; const { threadInfos } = threadStore;
const [entryStore, newEntryInconsistencies] = reduceEntryInfos( const { entryStore, reportCreationRequests: newEntryInconsistencies } =
state.entryStore, reduceEntryInfos(state.entryStore, action, threadInfos);
action,
threadInfos,
);
const onStateDifferenceForStaff = (message: string) => { const onStateDifferenceForStaff = (message: string) => {
const isCurrentUserStaff = state.currentUserInfo?.id const isCurrentUserStaff = state.currentUserInfo?.id
? isStaff(state.currentUserInfo.id) ? isStaff(state.currentUserInfo.id)
: false; : false;
if (isCurrentUserStaff || isDev) { if (isCurrentUserStaff || isDev) {
onStateDifference(message); onStateDifference(message);
} }
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/entry-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...