- Cleans messy TunnelbrokerContext
- Makes it possible to convert peerToPeerMessageHandler to a hook and avoids passing a lot of callbacks as arguments
- Makes it possible to call sendMessage from peerToPeerMessageHandler (needed to implement ENG-7837).
Details
Details
Flow - this is just moving code to a child component. Functionality tested later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- land-peer-list
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 395–404 ↗ | (On Diff #41151) | not sure about best practices but this feels the best for this particular use case (passing ref as prop and reading it from promise later) |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 422 ↗ | (On Diff #41151) | Unusual pattern to use "if" in a boolean variable name How about doesSocketExist? |