Paths

Table of Contentst

Differential D12378

[Identity] send `IdentityDeviceListUpdated` after logout
ClosedPublic
Actions

Authored by kamil on Jun 10 2024, 5:06 AM.

Tags

None

Referenced Files

	F3361446: D12378.diff
	Sun, Nov 24, 5:31 PM

	Unknown Object (File)
	Wed, Nov 20, 2:40 PM

	Unknown Object (File)
	Wed, Nov 20, 2:40 PM

	Unknown Object (File)
	Fri, Nov 8, 7:14 PM

	Unknown Object (File)
	Fri, Nov 8, 1:52 PM

	Unknown Object (File)
	Oct 22 2024, 1:16 PM

	Unknown Object (File)
	Oct 22 2024, 9:04 AM

	Unknown Object (File)
	Oct 22 2024, 8:34 AM

View All 57 Files

Subscribers

Details

Reviewers

bartek
tomek
varun

Commits

rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout

Summary

Part of ENG-7837.

Sending messages to devices remained on device list.

Depends on D12377

Test Plan

Run local TB, and Identity, and make all clients connect to it.
usingCommServicesAccessToken = true
Login on multiple devices (2 devices of user A, 1 device of user B but A is aware of B).
Log out on one of A's devices (the device that was last logged in - updates after login are not ready yet).
Other A device should receive an update and fetch an updated device list
B device should receive an update and fetch the device list for B

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 10 2024, 5:06 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 10 2024, 5:06 AM

Harbormaster completed remote builds in B29572: Diff 41159.Jun 10 2024, 5:23 AM

kamil added a child revision: D12379: [lib] handle `DEVICE_LIST_UPDATED` message.Jun 10 2024, 8:52 AM

kamil mentioned this in D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.Jun 10 2024, 9:42 AM

kamil mentioned this in D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.

kamil edited the summary of this revision. (Show Details)Jun 10 2024, 9:46 AM

kamil edited the test plan for this revision. (Show Details)

kamil published this revision for review.Jun 10 2024, 9:52 AM

Besides that LGTM

services/identity/src/grpc_services/authenticated.rs
354–361 ↗	(On Diff #41159)	Commented in D12377 - modifying `send_device_list_update()` to accept list of device IDs and creating a single `tokio::spawn` task for all of them might be more efficient.

tomek accepted this revision.Jun 13 2024, 3:14 AM

This revision is now accepted and ready to land.Jun 13 2024, 3:14 AM

address review

Harbormaster completed remote builds in B29665: Diff 41289.Jun 13 2024, 8:56 AM

Closed by commit rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout (authored by kamil). · Explain WhyJun 13 2024, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM6488eee28c83: [lib] add `IdentityDeviceListUpdated` P2P message type.

kamil mentioned this in rCOMMafda4a8565f3: [lib] handle `IdentityDeviceListUpdated` P2P message.

kamil added a commit: rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout.

kamil mentioned this in D12438: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:30 AM

kamil mentioned this in rCOMM47f0ef750274: [terraform] Deploy Identity `0.23-staging` to staging.Jun 14 2024, 2:55 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

37 lines

Diff 41302

services/identity/src/grpc_services/authenticated.rs

Loading...