Page MenuHomePhabricator

[native] update QR login flow to use `QRAuthContext`
ClosedPublic

Authored by kamil on Jun 17 2024, 4:02 AM.
Tags
None
Referenced Files
F3150909: D12452.diff
Tue, Nov 5, 1:25 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Sat, Oct 12, 12:01 PM
Unknown Object (File)
Sat, Oct 12, 12:01 PM
Unknown Object (File)
Sat, Oct 12, 12:01 PM
Unknown Object (File)
Sat, Oct 12, 12:01 PM
Unknown Object (File)
Sat, Oct 12, 12:01 PM
Unknown Object (File)
Sep 19 2024, 5:22 PM
Subscribers

Details

Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Rendering context and de-duplicating logic.

Depends on D12450

Test Plan

Test QR login flow on native. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable